Temporarily disable the error notifier running after indexing. #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (NetBeans) patch:
apache/netbeans@0d6fb1a
introduced a new feature, where errors for all files are reported from the LSP server to the client when indexing finishes.
But, it does so by taking the list of files with errors, and re-running the diagnostic task on them. When there are many files with errors, this may get very slow.
This PR speeds the process significantly, by reusing errors collected during indexing:
apache/netbeans#8206
but that patch could use some baking time, to see if there are any issues with it.
Hence here, I propose to disable the error publication after indexing for now. Note that if the file is opened in the editor, the errors should be published normally as before. The effect of this PR is that the behavior should be the same as in previous versions of this extension (before the NetBeans 25 upgrade).