Skip to content

added user configuration for setting up code completion commit characters #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

added user configuration for setting up code completion commit characters #418

merged 1 commit into from
May 2, 2025

Conversation

Achal1607
Copy link
Member

  • Currently dot(".") is provided by default as the code completion commit character alongwith Tab and Enter.
  • According to VSCode guidelines and modern IDEs behaviour we should only provide Tab and Enter for accepting code completion suggestions. So, removed the default . character for accepting code completion.
  • But, since some users might be already using . as their code completion character. Introduced a new configuration jdk.java.completion.commit.chars which accepts array of character for code completion commit.

@Achal1607 Achal1607 requested a review from sid-srini April 30, 2025 08:30
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 30, 2025
@Achal1607 Achal1607 added this to the JVSC 24.1.0 milestone Apr 30, 2025
sid-srini
sid-srini previously approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607. LGTM 👍

sid-srini
sid-srini approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@Achal1607 Achal1607 merged commit 8f0803d into oracle:main May 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid-srini sid-srini sid-srini approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
JVSC 24.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Achal1607 @sid-srini