Skip to content

Commit 1010f21

Browse files
Himanshu Madhanimartinkpetersen
authored andcommitted
scsi: qla2xxx: Initialize Work element before requesting IRQs
commit a9e170e ("scsi: qla2xxx: Fix uninitialized work element") moved initializiation of work element earlier in the probe to fix call stack. However, it still leaves a window where interrupt can be generated before work element is initialized. Fix that window by initializing work element before we are requesting IRQs. [mkp: fixed typos] Fixes: a9e170e ("scsi: qla2xxx: Fix uninitialized work element") Cc: <[email protected]> # 4.13 Signed-off-by: Himanshu Madhani <[email protected]> Signed-off-by: Quinn Tran <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent ab31fd0 commit 1010f21

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/scsi/qla2xxx/qla_os.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3061,6 +3061,8 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
30613061
host->max_cmd_len, host->max_channel, host->max_lun,
30623062
host->transportt, sht->vendor_id);
30633063

3064+
INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn);
3065+
30643066
/* Set up the irqs */
30653067
ret = qla2x00_request_irqs(ha, rsp);
30663068
if (ret)
@@ -3175,8 +3177,6 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
31753177
host->can_queue, base_vha->req,
31763178
base_vha->mgmt_svr_loop_id, host->sg_tablesize);
31773179

3178-
INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn);
3179-
31803180
if (ha->mqenable) {
31813181
bool mq = false;
31823182
bool startit = false;

0 commit comments

Comments
 (0)