netfilter: Fix format string of nfnetlink_log proc file

richardweinberger · davem330 · commit 20a1d16526b7 · 2015-04-13T16:35:17.000-04:00
The printed values are all of type unsigned integer, therefore use
%u instead of %d. Otherwise an user can face negative values.

Signed-off-by: Richard Weinberger &lt;richard@nod.at&gt;
Acked-by: Pablo Neira Ayuso &lt;pablo@netfilter.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
@@ -1007,7 +1007,7 @@ static int seq_show(struct seq_file *s, void *v)
 {
 	const struct nfulnl_instance *inst = v;
 
-	seq_printf(s, "%5d %6d %5d %1d %5d %6d %2d\n",
+	seq_printf(s, "%5u %6u %5u %1u %5u %6u %2u\n",
 		   inst->group_num,
 		   inst->peer_portid, inst->qlen,
 		   inst->copy_mode, inst->copy_range,

Original file line number	Diff line number	Diff line change
`@@ -1007,7 +1007,7 @@ static int seq_show(struct seq_file s, void v)`
`1007`	`1007`	`{`
`1008`	`1008`	`const struct nfulnl_instance *inst = v;`
`1009`	`1009`
`1010`		`- seq_printf(s, "%5d %6d %5d %1d %5d %6d %2d\n",`
	`1010`	`+ seq_printf(s, "%5u %6u %5u %1u %5u %6u %2u\n",`
`1011`	`1011`	`inst->group_num,`
`1012`	`1012`	`inst->peer_portid, inst->qlen,`
`1013`	`1013`	`inst->copy_mode, inst->copy_range,`