Skip to content

Commit 378da4a

Browse files
GustavoARSilvabroonie
authored andcommitted
spi/bcm63xx-hspi: fix error return code in bcm63xx_hsspi_probe()
platform_get_irq() returns an error code, but the spi-bcm63xx-hsspi driver ignores it and always returns -ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print and propagate the return value of platform_get_irq on failure. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Mark Brown <[email protected]>
1 parent ba8afe9 commit 378da4a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/spi/spi-bcm63xx-hsspi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,8 +338,8 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
338338

339339
irq = platform_get_irq(pdev, 0);
340340
if (irq < 0) {
341-
dev_err(dev, "no irq\n");
342-
return -ENXIO;
341+
dev_err(dev, "no irq: %d\n", irq);
342+
return irq;
343343
}
344344

345345
res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);

0 commit comments

Comments
 (0)