Skip to content

Commit 5007991

Browse files
Shravya KNPaolo Abeni
authored andcommitted
bnxt_en: Set backplane link modes correctly for ethtool
Use the return value from bnxt_get_media() to determine the port and link modes. bnxt_get_media() returns the proper BNXT_MEDIA_KR when the PHY is backplane. This will correct the ethtool settings for backplane devices. Fixes: 5d4e1bf ("bnxt_en: extend media types to supported and autoneg modes") Reviewed-by: Somnath Kotur <[email protected]> Signed-off-by: Shravya KN <[email protected]> Signed-off-by: Michael Chan <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent 5311598 commit 5007991

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2837,19 +2837,24 @@ static int bnxt_get_link_ksettings(struct net_device *dev,
28372837
}
28382838

28392839
base->port = PORT_NONE;
2840-
if (link_info->media_type == PORT_PHY_QCFG_RESP_MEDIA_TYPE_TP) {
2840+
if (media == BNXT_MEDIA_TP) {
28412841
base->port = PORT_TP;
28422842
linkmode_set_bit(ETHTOOL_LINK_MODE_TP_BIT,
28432843
lk_ksettings->link_modes.supported);
28442844
linkmode_set_bit(ETHTOOL_LINK_MODE_TP_BIT,
28452845
lk_ksettings->link_modes.advertising);
2846+
} else if (media == BNXT_MEDIA_KR) {
2847+
linkmode_set_bit(ETHTOOL_LINK_MODE_Backplane_BIT,
2848+
lk_ksettings->link_modes.supported);
2849+
linkmode_set_bit(ETHTOOL_LINK_MODE_Backplane_BIT,
2850+
lk_ksettings->link_modes.advertising);
28462851
} else {
28472852
linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
28482853
lk_ksettings->link_modes.supported);
28492854
linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
28502855
lk_ksettings->link_modes.advertising);
28512856

2852-
if (link_info->media_type == PORT_PHY_QCFG_RESP_MEDIA_TYPE_DAC)
2857+
if (media == BNXT_MEDIA_CR)
28532858
base->port = PORT_DA;
28542859
else
28552860
base->port = PORT_FIBRE;

0 commit comments

Comments
 (0)