Skip to content

Commit 50ec69e

Browse files
lkundrakgregkh
authored andcommitted
Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name"
commit 8c0f9f5 upstream. This changes UAPI, breaking iwd and libell: ell/key.c: In function 'kernel_dh_compute': ell/key.c:205:38: error: 'struct keyctl_dh_params' has no member named 'private'; did you mean 'dh_private'? struct keyctl_dh_params params = { .private = private, ^~~~~~~ dh_private This reverts commit 8a2336e. Fixes: 8a2336e ("uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name") Signed-off-by: Lubomir Rintel <[email protected]> Signed-off-by: David Howells <[email protected]> cc: Randy Dunlap <[email protected]> cc: Mat Martineau <[email protected]> cc: Stephan Mueller <[email protected]> cc: James Morris <[email protected]> cc: "Serge E. Hallyn" <[email protected]> cc: Mat Martineau <[email protected]> cc: Andrew Morton <[email protected]> cc: Linus Torvalds <[email protected]> cc: <[email protected]> Signed-off-by: James Morris <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 13d2161 commit 50ec69e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

include/uapi/linux/keyctl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565

6666
/* keyctl structures */
6767
struct keyctl_dh_params {
68-
__s32 dh_private;
68+
__s32 private;
6969
__s32 prime;
7070
__s32 base;
7171
};

security/keys/dh.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ long __keyctl_dh_compute(struct keyctl_dh_params __user *params,
307307
}
308308
dh_inputs.g_size = dlen;
309309

310-
dlen = dh_data_from_key(pcopy.dh_private, &dh_inputs.key);
310+
dlen = dh_data_from_key(pcopy.private, &dh_inputs.key);
311311
if (dlen < 0) {
312312
ret = dlen;
313313
goto out2;

0 commit comments

Comments
 (0)