Skip to content

Commit 5153b7b

Browse files
author
Sarah Sharp
committed
xhci: STFU: Don't print event ring dequeue pointer.
Stop printing out the event ring dequeue pointer and status register in the operational register set. The host will report an OK status 99% of the time the interrupt handler is called, and usually when it's really hosed, a host controller won't even call the interrupt handler. So the line is really useless. Signed-off-by: Sarah Sharp <[email protected]>
1 parent 380032c commit 5153b7b

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

drivers/usb/host/xhci-ring.c

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,7 @@ static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring, bool consumer
167167
next = ring->dequeue;
168168
}
169169
addr = (unsigned long long) xhci_trb_virt_to_dma(ring->deq_seg, ring->dequeue);
170-
if (ring == xhci->event_ring)
171-
xhci_dbg(xhci, "Event ring deq = 0x%llx (DMA)\n", addr);
172-
else if (ring == xhci->cmd_ring)
170+
if (ring == xhci->cmd_ring)
173171
xhci_dbg(xhci, "Command ring deq = 0x%llx (DMA)\n", addr);
174172
else
175173
xhci_dbg(xhci, "Ring deq = 0x%llx (DMA)\n", addr);
@@ -2267,16 +2265,6 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd)
22672265
spin_unlock(&xhci->lock);
22682266
return IRQ_NONE;
22692267
}
2270-
xhci_dbg(xhci, "op reg status = %08x\n", status);
2271-
xhci_dbg(xhci, "Event ring dequeue ptr:\n");
2272-
xhci_dbg(xhci, "@%llx %08x %08x %08x %08x\n",
2273-
(unsigned long long)
2274-
xhci_trb_virt_to_dma(xhci->event_ring->deq_seg, trb),
2275-
lower_32_bits(le64_to_cpu(trb->link.segment_ptr)),
2276-
upper_32_bits(le64_to_cpu(trb->link.segment_ptr)),
2277-
(unsigned int) le32_to_cpu(trb->link.intr_target),
2278-
(unsigned int) le32_to_cpu(trb->link.control));
2279-
22802268
if (status & STS_FATAL) {
22812269
xhci_warn(xhci, "WARNING: Host System Error\n");
22822270
xhci_halt(xhci);

0 commit comments

Comments
 (0)