Skip to content

Commit 57177d2

Browse files
Stefan Mavrodievmripard
authored andcommitted
drm/sun4i: hdmi: Remove duplicate cleanup calls
When the HDMI unbinds drm_connector_cleanup() and drm_encoder_cleanup() are called. This also happens when the connector and the encoder are destroyed. This double call triggers a NULL pointer exception. The patch fixes this by removing the cleanup calls in the unbind function. Cc: <[email protected]> Fixes: 9c56810 ("drm/sun4i: Add HDMI support") Signed-off-by: Stefan Mavrodiev <[email protected]> Signed-off-by: Maxime Ripard <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent d16f0f6 commit 57177d2

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -685,8 +685,6 @@ static void sun4i_hdmi_unbind(struct device *dev, struct device *master,
685685
struct sun4i_hdmi *hdmi = dev_get_drvdata(dev);
686686

687687
cec_unregister_adapter(hdmi->cec_adap);
688-
drm_connector_cleanup(&hdmi->connector);
689-
drm_encoder_cleanup(&hdmi->encoder);
690688
i2c_del_adapter(hdmi->i2c);
691689
i2c_put_adapter(hdmi->ddc_i2c);
692690
clk_disable_unprepare(hdmi->mod_clk);

0 commit comments

Comments
 (0)