Skip to content

Commit 5bc9e59

Browse files
petersennajhovold
authored andcommitted
USB: kl5kusb105: Remove klsi_105_tiocmset function
This patch remove the function klsi_105_tiocmset which was only returning -EINVAL. It also removes the function prototype and the .tiocmset entry in the struct usb_serial_driver. Verified by compilation only. Signed-off-by: Peter Senna Tschudin <[email protected]> Signed-off-by: Johan Hovold <[email protected]>
1 parent cca16d6 commit 5bc9e59

File tree

1 file changed

+0
-30
lines changed

1 file changed

+0
-30
lines changed

drivers/usb/serial/kl5kusb105.c

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ static void klsi_105_close(struct usb_serial_port *port);
6262
static void klsi_105_set_termios(struct tty_struct *tty,
6363
struct usb_serial_port *port, struct ktermios *old);
6464
static int klsi_105_tiocmget(struct tty_struct *tty);
65-
static int klsi_105_tiocmset(struct tty_struct *tty,
66-
unsigned int set, unsigned int clear);
6765
static void klsi_105_process_read_urb(struct urb *urb);
6866
static int klsi_105_prepare_write_buffer(struct usb_serial_port *port,
6967
void *dest, size_t size);
@@ -93,7 +91,6 @@ static struct usb_serial_driver kl5kusb105d_device = {
9391
.set_termios = klsi_105_set_termios,
9492
/*.break_ctl = klsi_105_break_ctl,*/
9593
.tiocmget = klsi_105_tiocmget,
96-
.tiocmset = klsi_105_tiocmset,
9794
.port_probe = klsi_105_port_probe,
9895
.port_remove = klsi_105_port_remove,
9996
.throttle = usb_serial_generic_throttle,
@@ -602,33 +599,6 @@ static int klsi_105_tiocmget(struct tty_struct *tty)
602599
return (int)line_state;
603600
}
604601

605-
static int klsi_105_tiocmset(struct tty_struct *tty,
606-
unsigned int set, unsigned int clear)
607-
{
608-
int retval = -EINVAL;
609-
610-
/* if this ever gets implemented, it should be done something like this:
611-
struct usb_serial *serial = port->serial;
612-
struct klsi_105_private *priv = usb_get_serial_port_data(port);
613-
unsigned long flags;
614-
int control;
615-
616-
spin_lock_irqsave (&priv->lock, flags);
617-
if (set & TIOCM_RTS)
618-
priv->control_state |= TIOCM_RTS;
619-
if (set & TIOCM_DTR)
620-
priv->control_state |= TIOCM_DTR;
621-
if (clear & TIOCM_RTS)
622-
priv->control_state &= ~TIOCM_RTS;
623-
if (clear & TIOCM_DTR)
624-
priv->control_state &= ~TIOCM_DTR;
625-
control = priv->control_state;
626-
spin_unlock_irqrestore (&priv->lock, flags);
627-
retval = mct_u232_set_modem_ctrl(serial, control);
628-
*/
629-
return retval;
630-
}
631-
632602
module_usb_serial_driver(serial_drivers, id_table);
633603

634604
MODULE_AUTHOR(DRIVER_AUTHOR);

0 commit comments

Comments
 (0)