ASoC: Return proper error for omap3pandora_soc_init

AxelLin · broonie · commit 5c12d20145ce · 2010-11-24T11:22:45.000Z
Return PTR_ERR(omap3pandora_dac_reg) instead of 0 if regulator_get failed.

Signed-off-by: Axel Lin &lt;axel.lin@gmail.com&gt;
Acked-by: Liam Girdwood &lt;lrg@slimlogic.co.uk&gt;
Signed-off-by: Mark Brown &lt;broonie@opensource.wolfsonmicro.com&gt;
diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c
@@ -306,6 +306,7 @@ static int __init omap3pandora_soc_init(void)
 		pr_err(PREFIX "Failed to get DAC regulator from %s: %ld\n",
 			dev_name(&omap3pandora_snd_device->dev),
 			PTR_ERR(omap3pandora_dac_reg));
+		ret = PTR_ERR(omap3pandora_dac_reg);
 		goto fail3;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -306,6 +306,7 @@ static int __init omap3pandora_soc_init(void)`
`306`	`306`	`pr_err(PREFIX "Failed to get DAC regulator from %s: %ld\n",`
`307`	`307`	`dev_name(&omap3pandora_snd_device->dev),`
`308`	`308`	`PTR_ERR(omap3pandora_dac_reg));`
	`309`	`+ ret = PTR_ERR(omap3pandora_dac_reg);`
`309`	`310`	`goto fail3;`
`310`	`311`	`}`
`311`	`312`