Skip to content

Commit 5e264e2

Browse files
Colin Ian Kingdavem330
authored andcommitted
vmxnet3: remove redundant initialization of pointer 'rq'
Pointer rq is being initialized but this value is never read, it is being updated inside a for-loop. Remove the initialization and move it into the scope of the for-loop. Cleans up clang warning: drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored to 'rq' during its initialization is never read Signed-off-by: Colin Ian King <[email protected]> Acked-by: Shrikrishna Khare <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 3b51cc7 commit 5e264e2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/net/vmxnet3/vmxnet3_drv.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2760,9 +2760,6 @@ static void
27602760
vmxnet3_adjust_rx_ring_size(struct vmxnet3_adapter *adapter)
27612761
{
27622762
size_t sz, i, ring0_size, ring1_size, comp_size;
2763-
struct vmxnet3_rx_queue *rq = &adapter->rx_queue[0];
2764-
2765-
27662763
if (adapter->netdev->mtu <= VMXNET3_MAX_SKB_BUF_SIZE -
27672764
VMXNET3_MAX_ETH_HDR_SIZE) {
27682765
adapter->skb_buf_size = adapter->netdev->mtu +
@@ -2794,7 +2791,8 @@ vmxnet3_adjust_rx_ring_size(struct vmxnet3_adapter *adapter)
27942791
comp_size = ring0_size + ring1_size;
27952792

27962793
for (i = 0; i < adapter->num_rx_queues; i++) {
2797-
rq = &adapter->rx_queue[i];
2794+
struct vmxnet3_rx_queue *rq = &adapter->rx_queue[i];
2795+
27982796
rq->rx_ring[0].size = ring0_size;
27992797
rq->rx_ring[1].size = ring1_size;
28002798
rq->comp_ring.size = comp_size;

0 commit comments

Comments
 (0)