Skip to content

Commit 60d354e

Browse files
committed
sunrpc: Don't do a dst_confirm() on an input routes.
xs_udp_data_ready() is operating on received packets, and tries to do a dst_confirm() on the dst attached to the SKB. This isn't right, dst confirmation is for output routes, not input rights. It's for resetting the timers on the nexthop neighbour entry for the route, indicating that we've got good evidence that we've successfully reached it. Signed-off-by: David S. Miller <[email protected]>
1 parent 3c521f2 commit 60d354e

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

net/sunrpc/xprtsock.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,9 +1014,6 @@ static void xs_udp_data_ready(struct sock *sk, int len)
10141014

10151015
UDPX_INC_STATS_BH(sk, UDP_MIB_INDATAGRAMS);
10161016

1017-
/* Something worked... */
1018-
dst_confirm(skb_dst(skb));
1019-
10201017
xprt_adjust_cwnd(task, copied);
10211018
xprt_complete_rqst(task, copied);
10221019

0 commit comments

Comments
 (0)