Skip to content

Commit 629821d

Browse files
committed
Revert "xen: netback: remove redundant xenvif_put"
This reverts commit d372045. This change is incorrect, as per Jan Beulich: ==================== But this is wrong from all we can tell, we discussed this before (Wei pointed to the discussion in an earlier reply). The core of it is that the put here parallels the one in netbk_tx_err(), and the one in xenvif_carrier_off() matches the get from xenvif_connect() (which normally would be done on the path coming through xenvif_disconnect()). ==================== And a previous discussion of this issue is at: http://marc.info/?l=xen-devel&m=136084174026977&w=2 Signed-off-by: David S. Miller <[email protected]>
1 parent 900ff8c commit 629821d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/xen-netback/netback.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -893,6 +893,7 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
893893
{
894894
netdev_err(vif->dev, "fatal error; disabling device\n");
895895
xenvif_carrier_off(vif);
896+
xenvif_put(vif);
896897
}
897898

898899
static int netbk_count_requests(struct xenvif *vif,

0 commit comments

Comments
 (0)