net: dsa: sja1105: error out on unsupported PHY mode

vladimiroltean · davem330 · commit 6729188d2646 · 2021-05-24T13:20:24.000-07:00
The driver continues probing when a port is configured for an unsupported PHY interface type, instead it should stop. Fixes: 8aa9ebc ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -207,6 +207,7 @@ static int sja1105_init_mii_settings(struct sja1105_private *priv,
 		default:
 			dev_err(dev, "Unsupported PHY mode %s!\n",
 				phy_modes(ports[i].phy_mode));
+			return -EINVAL;
 		}
 
 		/* Even though the SerDes port is able to drive SGMII autoneg

Original file line number	Diff line number	Diff line change
`@@ -207,6 +207,7 @@ static int sja1105_init_mii_settings(struct sja1105_private *priv,`
`207`	`207`	`default:`
`208`	`208`	`dev_err(dev, "Unsupported PHY mode %s!\n",`
`209`	`209`	`phy_modes(ports[i].phy_mode));`
	`210`	`+ return -EINVAL;`
`210`	`211`	`}`
`211`	`212`
`212`	`213`	`/* Even though the SerDes port is able to drive SGMII autoneg`