Skip to content

Commit 7fe3fa3

Browse files
Mario Limonciellodvhart
authored andcommitted
platform/x86: Kconfig: Fix dell-laptop dependency chain.
As reported by Randy Dunlap: >> WARNING: unmet direct dependencies detected for DELL_SMBIOS >> Depends on [m]: X86 [=y] && X86_PLATFORM_DEVICES [=y] >> && (DCDBAS [=m] || >> DCDBAS [=m]=n) && (ACPI_WMI [=n] || ACPI_WMI [=n]=n) >> Selected by [y]: >> - DELL_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] >> && DMI [=y] >> && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || >> ACPI_VIDEO [=n]=n) >> && (RFKILL [=n] || RFKILL [=n]=n) && SERIO_I8042 [=y] >> Right now it's possible to set dell laptop to compile in but this causes dell-smbios to compile in which breaks if dcdbas is a module. Dell laptop shouldn't select dell-smbios anymore, but depend on it. Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on DCDBAS) Reported-by: Randy Dunlap <[email protected]> Signed-off-by: Mario Limonciello <[email protected]> Cc: [email protected] Signed-off-by: Darren Hart (VMware) <[email protected]>
1 parent 9f0a93d commit 7fe3fa3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/platform/x86/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ config DELL_LAPTOP
154154
depends on ACPI_VIDEO || ACPI_VIDEO = n
155155
depends on RFKILL || RFKILL = n
156156
depends on SERIO_I8042
157-
select DELL_SMBIOS
157+
depends on DELL_SMBIOS
158158
select POWER_SUPPLY
159159
select LEDS_CLASS
160160
select NEW_LEDS

0 commit comments

Comments
 (0)