Skip to content

Commit 92fb7aa

Browse files
nathanchanceJeff Kirsher
authored andcommitted
i40e: Remove unnecessary print statement
Clang warns that the address of a pointer will always evaluated as true in a boolean context. drivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address of array 'vsi->active_vlans' will always evaluate to 'true' [-Wpointer-bool-conversion] vsi->active_vlans ? "<valid>" : "<null>"); ~~~~~^~~~~~~~~~~~ ~ ./include/linux/device.h:1431:33: note: expanded from macro 'dev_info' _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ 1 warning generated. Given that the statement shows that active_vlans is always valid, just remove the statement since it's not giving any useful information. Link: ClangBuiltLinux/linux#82 Signed-off-by: Nathan Chancellor <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 43ade6a commit 92fb7aa

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/net/ethernet/intel/i40e/i40e_debugfs.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,6 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)
132132
dev_info(&pf->pdev->dev, " vlan_features = 0x%08lx\n",
133133
(unsigned long int)nd->vlan_features);
134134
}
135-
dev_info(&pf->pdev->dev, " active_vlans is %s\n",
136-
vsi->active_vlans ? "<valid>" : "<null>");
137135
dev_info(&pf->pdev->dev,
138136
" flags = 0x%08lx, netdev_registered = %i, current_netdev_flags = 0x%04x\n",
139137
vsi->flags, vsi->netdev_registered, vsi->current_netdev_flags);

0 commit comments

Comments
 (0)