Skip to content

Commit 977697e

Browse files
mripardmripard
committed
drm/atomic: Pass the full state to planes atomic disable and update
The current atomic helpers have either their object state being passed as an argument or the full atomic state. The former is the pattern that was done at first, before switching to the latter for new hooks or when it was needed. Let's convert the remaining helpers to provide a consistent interface, this time with the planes atomic_update and atomic_disable. The conversion was done using the coccinelle script below, built tested on all the drivers. @@ identifier plane, plane_state; symbol state; @@ struct drm_plane_helper_funcs { ... void (*atomic_update)(struct drm_plane *plane, - struct drm_plane_state *plane_state); + struct drm_atomic_state *state); ... } @@ identifier plane, plane_state; symbol state; @@ struct drm_plane_helper_funcs { ... void (*atomic_disable)(struct drm_plane *plane, - struct drm_plane_state *plane_state); + struct drm_atomic_state *state); ... } @ plane_atomic_func @ identifier helpers; identifier func; @@ ( static const struct drm_plane_helper_funcs helpers = { ..., .atomic_update = func, ..., }; | static const struct drm_plane_helper_funcs helpers = { ..., .atomic_disable = func, ..., }; ) @@ struct drm_plane_helper_funcs *FUNCS; identifier f; identifier crtc_state; identifier plane, plane_state, state; expression e; @@ f(struct drm_crtc_state *crtc_state) { ... struct drm_atomic_state *state = e; <+... ( - FUNCS->atomic_disable(plane, plane_state) + FUNCS->atomic_disable(plane, state) | - FUNCS->atomic_update(plane, plane_state) + FUNCS->atomic_update(plane, state) ) ...+> } @@ identifier plane_atomic_func.func; identifier plane; symbol state; @@ func(struct drm_plane *plane, - struct drm_plane_state *state) + struct drm_plane_state *old_plane_state) { <... - state + old_plane_state ...> } @ ignores_old_state @ identifier plane_atomic_func.func; identifier plane, old_state; @@ func(struct drm_plane *plane, struct drm_plane_state *old_state) { ... when != old_state } @ adds_old_state depends on plane_atomic_func && !ignores_old_state @ identifier plane_atomic_func.func; identifier plane, plane_state; @@ func(struct drm_plane *plane, struct drm_plane_state *plane_state) { + struct drm_plane_state *plane_state = drm_atomic_get_old_plane_state(state, plane); ... } @ depends on plane_atomic_func @ identifier plane_atomic_func.func; identifier plane, plane_state; @@ func(struct drm_plane *plane, - struct drm_plane_state *plane_state + struct drm_atomic_state *state ) { ... } @ include depends on adds_old_state @ @@ #include <drm/drm_atomic.h> @ no_include depends on !include && adds_old_state @ @@ + #include <drm/drm_atomic.h> #include <drm/...> @@ identifier plane_atomic_func.func; identifier plane, state; identifier plane_state; @@ func(struct drm_plane *plane, struct drm_atomic_state *state) { ... struct drm_plane_state *plane_state = drm_atomic_get_old_plane_state(state, plane); <+... - plane_state->state + state ...+> } Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Maxime Ripard <[email protected]> Acked-by: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 41016fe commit 977697e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+207
-123
lines changed

‎drivers/gpu/drm/arc/arcpgu_crtc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = {
145145
};
146146

147147
static void arc_pgu_plane_atomic_update(struct drm_plane *plane,
148-
struct drm_plane_state *state)
148+
struct drm_atomic_state *state)
149149
{
150150
struct drm_plane_state *new_plane_state = plane->state;
151151
struct arcpgu_drm_private *arcpgu;

‎drivers/gpu/drm/arm/display/komeda/komeda_plane.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ komeda_plane_atomic_check(struct drm_plane *plane,
116116
*/
117117
static void
118118
komeda_plane_atomic_update(struct drm_plane *plane,
119-
struct drm_plane_state *old_state)
119+
struct drm_atomic_state *state)
120120
{
121121
}
122122

‎drivers/gpu/drm/arm/hdlcd_crtc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ static int hdlcd_plane_atomic_check(struct drm_plane *plane,
260260
}
261261

262262
static void hdlcd_plane_atomic_update(struct drm_plane *plane,
263-
struct drm_plane_state *state)
263+
struct drm_atomic_state *state)
264264
{
265265
struct drm_plane_state *new_plane_state = plane->state;
266266
struct drm_framebuffer *fb = new_plane_state->fb;

‎drivers/gpu/drm/arm/malidp_planes.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -791,8 +791,10 @@ static void malidp_de_set_plane_afbc(struct drm_plane *plane)
791791
}
792792

793793
static void malidp_de_plane_update(struct drm_plane *plane,
794-
struct drm_plane_state *old_state)
794+
struct drm_atomic_state *state)
795795
{
796+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
797+
plane);
796798
struct malidp_plane *mp;
797799
struct malidp_plane_state *ms = to_malidp_plane_state(plane->state);
798800
struct drm_plane_state *new_state = plane->state;
@@ -909,7 +911,7 @@ static void malidp_de_plane_update(struct drm_plane *plane,
909911
}
910912

911913
static void malidp_de_plane_disable(struct drm_plane *plane,
912-
struct drm_plane_state *state)
914+
struct drm_atomic_state *state)
913915
{
914916
struct malidp_plane *mp = to_malidp_plane(plane);
915917

‎drivers/gpu/drm/armada/armada_overlay.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,10 @@ static inline u32 armada_csc(struct drm_plane_state *state)
6666

6767
/* === Plane support === */
6868
static void armada_drm_overlay_plane_atomic_update(struct drm_plane *plane,
69-
struct drm_plane_state *old_state)
69+
struct drm_atomic_state *state)
7070
{
71+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
72+
plane);
7173
struct drm_plane_state *new_state = plane->state;
7274
struct armada_crtc *dcrtc;
7375
struct armada_regs *regs;
@@ -214,8 +216,10 @@ static void armada_drm_overlay_plane_atomic_update(struct drm_plane *plane,
214216
}
215217

216218
static void armada_drm_overlay_plane_atomic_disable(struct drm_plane *plane,
217-
struct drm_plane_state *old_state)
219+
struct drm_atomic_state *state)
218220
{
221+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
222+
plane);
219223
struct armada_crtc *dcrtc;
220224
struct armada_regs *regs;
221225
unsigned int idx = 0;

‎drivers/gpu/drm/armada/armada_plane.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,10 @@ int armada_drm_plane_atomic_check(struct drm_plane *plane,
161161
}
162162

163163
static void armada_drm_primary_plane_atomic_update(struct drm_plane *plane,
164-
struct drm_plane_state *old_state)
164+
struct drm_atomic_state *state)
165165
{
166+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
167+
plane);
166168
struct drm_plane_state *new_state = plane->state;
167169
struct armada_crtc *dcrtc;
168170
struct armada_regs *regs;
@@ -248,8 +250,10 @@ static void armada_drm_primary_plane_atomic_update(struct drm_plane *plane,
248250
}
249251

250252
static void armada_drm_primary_plane_atomic_disable(struct drm_plane *plane,
251-
struct drm_plane_state *old_state)
253+
struct drm_atomic_state *state)
252254
{
255+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
256+
plane);
253257
struct armada_crtc *dcrtc;
254258
struct armada_regs *regs;
255259
unsigned int idx = 0;

‎drivers/gpu/drm/ast/ast_mode.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -569,8 +569,10 @@ static int ast_primary_plane_helper_atomic_check(struct drm_plane *plane,
569569

570570
static void
571571
ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
572-
struct drm_plane_state *old_state)
572+
struct drm_atomic_state *state)
573573
{
574+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
575+
plane);
574576
struct drm_device *dev = plane->dev;
575577
struct ast_private *ast = to_ast_private(dev);
576578
struct drm_plane_state *new_state = plane->state;
@@ -601,7 +603,7 @@ ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
601603

602604
static void
603605
ast_primary_plane_helper_atomic_disable(struct drm_plane *plane,
604-
struct drm_plane_state *old_state)
606+
struct drm_atomic_state *state)
605607
{
606608
struct ast_private *ast = to_ast_private(plane->dev);
607609

@@ -790,9 +792,11 @@ static int ast_cursor_plane_helper_atomic_check(struct drm_plane *plane,
790792

791793
static void
792794
ast_cursor_plane_helper_atomic_update(struct drm_plane *plane,
793-
struct drm_plane_state *old_state)
795+
struct drm_atomic_state *state)
794796
{
795797
struct ast_cursor_plane *ast_cursor_plane = to_ast_cursor_plane(plane);
798+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
799+
plane);
796800
struct drm_plane_state *new_state = plane->state;
797801
struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(new_state);
798802
struct drm_framebuffer *fb = new_state->fb;
@@ -860,7 +864,7 @@ ast_cursor_plane_helper_atomic_update(struct drm_plane *plane,
860864

861865
static void
862866
ast_cursor_plane_helper_atomic_disable(struct drm_plane *plane,
863-
struct drm_plane_state *old_state)
867+
struct drm_atomic_state *state)
864868
{
865869
struct ast_private *ast = to_ast_private(plane->dev);
866870

‎drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,7 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
712712
}
713713

714714
static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
715-
struct drm_plane_state *old_state)
715+
struct drm_atomic_state *state)
716716
{
717717
struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
718718

@@ -731,7 +731,7 @@ static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
731731
}
732732

733733
static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
734-
struct drm_plane_state *old_s)
734+
struct drm_atomic_state *state)
735735
{
736736
struct drm_plane_state *new_s = p->state;
737737
struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
@@ -743,7 +743,7 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
743743
return;
744744

745745
if (!hstate->base.visible) {
746-
atmel_hlcdc_plane_atomic_disable(p, old_s);
746+
atmel_hlcdc_plane_atomic_disable(p, state);
747747
return;
748748
}
749749

‎drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2528,9 +2528,9 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev,
25282528
no_disable)
25292529
continue;
25302530

2531-
funcs->atomic_disable(plane, old_plane_state);
2531+
funcs->atomic_disable(plane, old_state);
25322532
} else if (new_plane_state->crtc || disabling) {
2533-
funcs->atomic_update(plane, old_plane_state);
2533+
funcs->atomic_update(plane, old_state);
25342534
}
25352535
}
25362536

@@ -2602,10 +2602,10 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state)
26022602

26032603
if (drm_atomic_plane_disabling(old_plane_state, new_plane_state) &&
26042604
plane_funcs->atomic_disable)
2605-
plane_funcs->atomic_disable(plane, old_plane_state);
2605+
plane_funcs->atomic_disable(plane, old_state);
26062606
else if (new_plane_state->crtc ||
26072607
drm_atomic_plane_disabling(old_plane_state, new_plane_state))
2608-
plane_funcs->atomic_update(plane, old_plane_state);
2608+
plane_funcs->atomic_update(plane, old_state);
26092609
}
26102610

26112611
if (crtc_funcs && crtc_funcs->atomic_flush)

‎drivers/gpu/drm/drm_simple_kms_helper.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,10 @@ static int drm_simple_kms_plane_atomic_check(struct drm_plane *plane,
206206
}
207207

208208
static void drm_simple_kms_plane_atomic_update(struct drm_plane *plane,
209-
struct drm_plane_state *old_pstate)
209+
struct drm_atomic_state *state)
210210
{
211+
struct drm_plane_state *old_pstate = drm_atomic_get_old_plane_state(state,
212+
plane);
211213
struct drm_simple_display_pipe *pipe;
212214

213215
pipe = container_of(plane, struct drm_simple_display_pipe, plane);

‎drivers/gpu/drm/exynos/exynos_drm_plane.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ static int exynos_plane_atomic_check(struct drm_plane *plane,
252252
}
253253

254254
static void exynos_plane_atomic_update(struct drm_plane *plane,
255-
struct drm_plane_state *old_state)
255+
struct drm_atomic_state *state)
256256
{
257257
struct drm_plane_state *new_state = plane->state;
258258
struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(new_state->crtc);
@@ -266,8 +266,9 @@ static void exynos_plane_atomic_update(struct drm_plane *plane,
266266
}
267267

268268
static void exynos_plane_atomic_disable(struct drm_plane *plane,
269-
struct drm_plane_state *old_state)
269+
struct drm_atomic_state *state)
270270
{
271+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state, plane);
271272
struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane);
272273
struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(old_state->crtc);
273274

‎drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ static int fsl_dcu_drm_plane_atomic_check(struct drm_plane *plane,
6060
}
6161

6262
static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
63-
struct drm_plane_state *old_state)
63+
struct drm_atomic_state *state)
6464
{
6565
struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;
6666
unsigned int value;
@@ -76,7 +76,7 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
7676
}
7777

7878
static void fsl_dcu_drm_plane_atomic_update(struct drm_plane *plane,
79-
struct drm_plane_state *old_state)
79+
struct drm_atomic_state *state)
8080

8181
{
8282
struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;

‎drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ static int hibmc_plane_atomic_check(struct drm_plane *plane,
9999
}
100100

101101
static void hibmc_plane_atomic_update(struct drm_plane *plane,
102-
struct drm_plane_state *old_state)
102+
struct drm_atomic_state *state)
103103
{
104104
struct drm_plane_state *new_state = plane->state;
105105
u32 reg;

‎drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,7 @@ static int ade_plane_atomic_check(struct drm_plane *plane,
804804
}
805805

806806
static void ade_plane_atomic_update(struct drm_plane *plane,
807-
struct drm_plane_state *old_state)
807+
struct drm_atomic_state *state)
808808
{
809809
struct drm_plane_state *new_state = plane->state;
810810
struct kirin_plane *kplane = to_kirin_plane(plane);
@@ -817,7 +817,7 @@ static void ade_plane_atomic_update(struct drm_plane *plane,
817817
}
818818

819819
static void ade_plane_atomic_disable(struct drm_plane *plane,
820-
struct drm_plane_state *old_state)
820+
struct drm_atomic_state *state)
821821
{
822822
struct kirin_plane *kplane = to_kirin_plane(plane);
823823

‎drivers/gpu/drm/imx/dcss/dcss-plane.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,10 @@ static bool dcss_plane_needs_setup(struct drm_plane_state *state,
264264
}
265265

266266
static void dcss_plane_atomic_update(struct drm_plane *plane,
267-
struct drm_plane_state *old_state)
267+
struct drm_atomic_state *state)
268268
{
269+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
270+
plane);
269271
struct drm_plane_state *new_state = plane->state;
270272
struct dcss_plane *dcss_plane = to_dcss_plane(plane);
271273
struct dcss_dev *dcss = plane->dev->dev_private;
@@ -346,7 +348,7 @@ static void dcss_plane_atomic_update(struct drm_plane *plane,
346348
}
347349

348350
static void dcss_plane_atomic_disable(struct drm_plane *plane,
349-
struct drm_plane_state *old_state)
351+
struct drm_atomic_state *state)
350352
{
351353
struct dcss_plane *dcss_plane = to_dcss_plane(plane);
352354
struct dcss_dev *dcss = plane->dev->dev_private;

‎drivers/gpu/drm/imx/ipuv3-plane.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ static int ipu_plane_atomic_check(struct drm_plane *plane,
494494
}
495495

496496
static void ipu_plane_atomic_disable(struct drm_plane *plane,
497-
struct drm_plane_state *old_state)
497+
struct drm_atomic_state *state)
498498
{
499499
struct ipu_plane *ipu_plane = to_ipu_plane(plane);
500500

@@ -539,8 +539,10 @@ static void ipu_calculate_bursts(u32 width, u32 cpp, u32 stride,
539539
}
540540

541541
static void ipu_plane_atomic_update(struct drm_plane *plane,
542-
struct drm_plane_state *old_state)
542+
struct drm_atomic_state *state)
543543
{
544+
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
545+
plane);
544546
struct ipu_plane *ipu_plane = to_ipu_plane(plane);
545547
struct drm_plane_state *new_state = plane->state;
546548
struct ipu_plane_state *ipu_state = to_ipu_plane_state(new_state);

‎drivers/gpu/drm/ingenic/ingenic-drm-drv.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ void ingenic_drm_plane_disable(struct device *dev, struct drm_plane *plane)
444444
}
445445

446446
static void ingenic_drm_plane_atomic_disable(struct drm_plane *plane,
447-
struct drm_plane_state *old_state)
447+
struct drm_atomic_state *state)
448448
{
449449
struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
450450

@@ -542,7 +542,7 @@ static void ingenic_drm_update_palette(struct ingenic_drm *priv,
542542
}
543543

544544
static void ingenic_drm_plane_atomic_update(struct drm_plane *plane,
545-
struct drm_plane_state *oldstate)
545+
struct drm_atomic_state *state)
546546
{
547547
struct ingenic_drm *priv = drm_device_get_priv(plane->dev);
548548
struct drm_plane_state *newstate = plane->state;

‎drivers/gpu/drm/ingenic/ingenic-ipu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ static inline bool osd_changed(struct drm_plane_state *state,
282282
}
283283

284284
static void ingenic_ipu_plane_atomic_update(struct drm_plane *plane,
285-
struct drm_plane_state *oldstate)
285+
struct drm_atomic_state *state)
286286
{
287287
struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
288288
struct drm_plane_state *newstate = plane->state;
@@ -595,7 +595,7 @@ static int ingenic_ipu_plane_atomic_check(struct drm_plane *plane,
595595
}
596596

597597
static void ingenic_ipu_plane_atomic_disable(struct drm_plane *plane,
598-
struct drm_plane_state *old_state)
598+
struct drm_atomic_state *state)
599599
{
600600
struct ingenic_ipu *ipu = plane_to_ingenic_ipu(plane);
601601

‎drivers/gpu/drm/kmb/kmb_plane.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ static int kmb_plane_atomic_check(struct drm_plane *plane,
110110
}
111111

112112
static void kmb_plane_atomic_disable(struct drm_plane *plane,
113-
struct drm_plane_state *state)
113+
struct drm_atomic_state *state)
114114
{
115115
struct kmb_plane *kmb_plane = to_kmb_plane(plane);
116116
int plane_id = kmb_plane->id;
@@ -278,8 +278,10 @@ static void config_csc(struct kmb_drm_private *kmb, int plane_id)
278278
}
279279

280280
static void kmb_plane_atomic_update(struct drm_plane *plane,
281-
struct drm_plane_state *state)
281+
struct drm_atomic_state *state)
282282
{
283+
struct drm_plane_state *old_plane_state = drm_atomic_get_old_plane_state(state,
284+
plane);
283285
struct drm_plane_state *new_plane_state = plane->state;
284286
struct drm_framebuffer *fb;
285287
struct kmb_drm_private *kmb;
@@ -294,7 +296,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
294296
int num_planes;
295297
static dma_addr_t addr[MAX_SUB_PLANES];
296298

297-
if (!plane || !new_plane_state || !state)
299+
if (!plane || !new_plane_state || !old_plane_state)
298300
return;
299301

300302
fb = new_plane_state->fb;

‎drivers/gpu/drm/mediatek/mtk_drm_crtc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ int mtk_drm_crtc_plane_check(struct drm_crtc *crtc, struct drm_plane *plane,
506506
}
507507

508508
void mtk_drm_crtc_async_update(struct drm_crtc *crtc, struct drm_plane *plane,
509-
struct drm_plane_state *new_state)
509+
struct drm_atomic_state *state)
510510
{
511511
struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
512512
const struct drm_plane_helper_funcs *plane_helper_funcs =
@@ -515,7 +515,7 @@ void mtk_drm_crtc_async_update(struct drm_crtc *crtc, struct drm_plane *plane,
515515
if (!mtk_crtc->enabled)
516516
return;
517517

518-
plane_helper_funcs->atomic_update(plane, new_state);
518+
plane_helper_funcs->atomic_update(plane, state);
519519
mtk_drm_crtc_hw_config(mtk_crtc);
520520
}
521521

0 commit comments

Comments
 (0)