Skip to content

Commit 9913db0

Browse files
etantilovJeff Kirsher
authored andcommitted
ixgbevf: use page_address offset from page
Based on commit 3456fd5 ("igb: Use page_address offset from page instead of masking virtual address") Update the handling of page addresses so that we always refer to them using a void pointer, and try to use the consistent name of va indicating we are working with a virtual address. Signed-off-by: Emil Tantilov <[email protected]> Tested-by: Krishneil Singh <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 6704a3a commit 9913db0

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ static bool ixgbevf_add_rx_frag(struct ixgbevf_ring *rx_ring,
795795
struct sk_buff *skb)
796796
{
797797
struct page *page = rx_buffer->page;
798-
unsigned char *va = page_address(page) + rx_buffer->page_offset;
798+
void *va = page_address(page) + rx_buffer->page_offset;
799799
#if (PAGE_SIZE < 8192)
800800
unsigned int truesize = IXGBEVF_RX_BUFSZ;
801801
#else
@@ -831,7 +831,7 @@ static bool ixgbevf_add_rx_frag(struct ixgbevf_ring *rx_ring,
831831

832832
add_tail_frag:
833833
skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, page,
834-
(unsigned long)va & ~PAGE_MASK, size, truesize);
834+
va - page_address(page), size, truesize);
835835

836836
return ixgbevf_can_reuse_rx_page(rx_buffer, page, truesize);
837837
}
@@ -856,13 +856,12 @@ static struct sk_buff *ixgbevf_fetch_rx_buffer(struct ixgbevf_ring *rx_ring,
856856
DMA_FROM_DEVICE);
857857

858858
if (likely(!skb)) {
859-
void *page_addr = page_address(page) +
860-
rx_buffer->page_offset;
859+
void *va = page_address(page) + rx_buffer->page_offset;
861860

862861
/* prefetch first cache line of first page */
863-
prefetch(page_addr);
862+
prefetch(va);
864863
#if L1_CACHE_BYTES < 128
865-
prefetch(page_addr + L1_CACHE_BYTES);
864+
prefetch(va + L1_CACHE_BYTES);
866865
#endif
867866

868867
/* allocate a skb to store the frags */

0 commit comments

Comments
 (0)