Skip to content

Commit a183b63

Browse files
committed
KVM: x86: make apic_accept_irq tracepoint more generic
Initially the tracepoint was added only to the APIC_DM_FIXED case, also because it reported coalesced interrupts that only made sense for that case. However, the coalesced argument is not used anymore and tracing other delivery modes is useful, so hoist the call out of the switch statement. Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 73a6d94 commit a183b63

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

arch/x86/kvm/lapic.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -709,6 +709,8 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
709709
int result = 0;
710710
struct kvm_vcpu *vcpu = apic->vcpu;
711711

712+
trace_kvm_apic_accept_irq(vcpu->vcpu_id, delivery_mode,
713+
trig_mode, vector);
712714
switch (delivery_mode) {
713715
case APIC_DM_LOWEST:
714716
vcpu->arch.apic_arb_prio++;
@@ -730,8 +732,6 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
730732
kvm_make_request(KVM_REQ_EVENT, vcpu);
731733
kvm_vcpu_kick(vcpu);
732734
}
733-
trace_kvm_apic_accept_irq(vcpu->vcpu_id, delivery_mode,
734-
trig_mode, vector, false);
735735
break;
736736

737737
case APIC_DM_REMRD:

arch/x86/kvm/trace.h

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -415,30 +415,27 @@ TRACE_EVENT(kvm_apic_ipi,
415415
);
416416

417417
TRACE_EVENT(kvm_apic_accept_irq,
418-
TP_PROTO(__u32 apicid, __u16 dm, __u8 tm, __u8 vec, bool coalesced),
419-
TP_ARGS(apicid, dm, tm, vec, coalesced),
418+
TP_PROTO(__u32 apicid, __u16 dm, __u8 tm, __u8 vec),
419+
TP_ARGS(apicid, dm, tm, vec),
420420

421421
TP_STRUCT__entry(
422422
__field( __u32, apicid )
423423
__field( __u16, dm )
424424
__field( __u8, tm )
425425
__field( __u8, vec )
426-
__field( bool, coalesced )
427426
),
428427

429428
TP_fast_assign(
430429
__entry->apicid = apicid;
431430
__entry->dm = dm;
432431
__entry->tm = tm;
433432
__entry->vec = vec;
434-
__entry->coalesced = coalesced;
435433
),
436434

437-
TP_printk("apicid %x vec %u (%s|%s)%s",
435+
TP_printk("apicid %x vec %u (%s|%s)",
438436
__entry->apicid, __entry->vec,
439437
__print_symbolic((__entry->dm >> 8 & 0x7), kvm_deliver_mode),
440-
__entry->tm ? "level" : "edge",
441-
__entry->coalesced ? " (coalesced)" : "")
438+
__entry->tm ? "level" : "edge")
442439
);
443440

444441
TRACE_EVENT(kvm_eoi,

0 commit comments

Comments
 (0)