Skip to content

Commit a2fa83f

Browse files
committed
Merge branch 'usb-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
* 'usb-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6: USB: fix regression occurring during device removal USB: fsl_udc_core: fix build breakage when building for ARM arch
2 parents 2d12a18 + e534c5b commit a2fa83f

File tree

2 files changed

+26
-12
lines changed

2 files changed

+26
-12
lines changed

drivers/usb/core/message.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,6 +1286,8 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
12861286
interface);
12871287
return -EINVAL;
12881288
}
1289+
if (iface->unregistering)
1290+
return -ENODEV;
12891291

12901292
alt = usb_altnum_to_altsetting(iface, alternate);
12911293
if (!alt) {

drivers/usb/gadget/fsl_udc_core.c

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
#include <asm/system.h>
4747
#include <asm/unaligned.h>
4848
#include <asm/dma.h>
49-
#include <asm/cacheflush.h>
5049

5150
#include "fsl_usb2_udc.h"
5251

@@ -118,6 +117,17 @@ static void (*_fsl_writel)(u32 v, unsigned __iomem *p);
118117
#define fsl_readl(p) (*_fsl_readl)((p))
119118
#define fsl_writel(v, p) (*_fsl_writel)((v), (p))
120119

120+
static inline void fsl_set_accessors(struct fsl_usb2_platform_data *pdata)
121+
{
122+
if (pdata->big_endian_mmio) {
123+
_fsl_readl = _fsl_readl_be;
124+
_fsl_writel = _fsl_writel_be;
125+
} else {
126+
_fsl_readl = _fsl_readl_le;
127+
_fsl_writel = _fsl_writel_le;
128+
}
129+
}
130+
121131
static inline u32 cpu_to_hc32(const u32 x)
122132
{
123133
return udc_controller->pdata->big_endian_desc
@@ -132,6 +142,8 @@ static inline u32 hc32_to_cpu(const u32 x)
132142
: le32_to_cpu((__force __le32)x);
133143
}
134144
#else /* !CONFIG_PPC32 */
145+
static inline void fsl_set_accessors(struct fsl_usb2_platform_data *pdata) {}
146+
135147
#define fsl_readl(addr) readl(addr)
136148
#define fsl_writel(val32, addr) writel(val32, addr)
137149
#define cpu_to_hc32(x) cpu_to_le32(x)
@@ -1277,6 +1289,11 @@ static int ep0_prime_status(struct fsl_udc *udc, int direction)
12771289
req->req.complete = NULL;
12781290
req->dtd_count = 0;
12791291

1292+
req->req.dma = dma_map_single(ep->udc->gadget.dev.parent,
1293+
req->req.buf, req->req.length,
1294+
ep_is_in(ep) ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
1295+
req->mapped = 1;
1296+
12801297
if (fsl_req_to_dtd(req) == 0)
12811298
fsl_queue_td(ep, req);
12821299
else
@@ -1348,16 +1365,18 @@ static void ch9getstatus(struct fsl_udc *udc, u8 request_type, u16 value,
13481365
/* Fill in the reqest structure */
13491366
*((u16 *) req->req.buf) = cpu_to_le16(tmp);
13501367

1351-
/* flush cache for the req buffer */
1352-
flush_dcache_range((u32)req->req.buf, (u32)req->req.buf + 8);
1353-
13541368
req->ep = ep;
13551369
req->req.length = 2;
13561370
req->req.status = -EINPROGRESS;
13571371
req->req.actual = 0;
13581372
req->req.complete = NULL;
13591373
req->dtd_count = 0;
13601374

1375+
req->req.dma = dma_map_single(ep->udc->gadget.dev.parent,
1376+
req->req.buf, req->req.length,
1377+
ep_is_in(ep) ? DMA_TO_DEVICE : DMA_FROM_DEVICE);
1378+
req->mapped = 1;
1379+
13611380
/* prime the data phase */
13621381
if ((fsl_req_to_dtd(req) == 0))
13631382
fsl_queue_td(ep, req);
@@ -2354,7 +2373,6 @@ static int __init struct_udc_setup(struct fsl_udc *udc,
23542373
struct fsl_req, req);
23552374
/* allocate a small amount of memory to get valid address */
23562375
udc->status_req->req.buf = kmalloc(8, GFP_KERNEL);
2357-
udc->status_req->req.dma = virt_to_phys(udc->status_req->req.buf);
23582376

23592377
udc->resume_state = USB_STATE_NOTATTACHED;
23602378
udc->usb_state = USB_STATE_POWERED;
@@ -2470,13 +2488,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
24702488
}
24712489

24722490
/* Set accessors only after pdata->init() ! */
2473-
if (pdata->big_endian_mmio) {
2474-
_fsl_readl = _fsl_readl_be;
2475-
_fsl_writel = _fsl_writel_be;
2476-
} else {
2477-
_fsl_readl = _fsl_readl_le;
2478-
_fsl_writel = _fsl_writel_le;
2479-
}
2491+
fsl_set_accessors(pdata);
24802492

24812493
#ifndef CONFIG_ARCH_MXC
24822494
if (pdata->have_sysif_regs)

0 commit comments

Comments
 (0)