Skip to content

Commit a51c76b

Browse files
liuhangbindavem330
authored andcommitted
cls_matchall: fix tcf_unbind_filter missing
Fix tcf_unbind_filter missing in cls_matchall as this will trigger WARN_ON() in cbq_destroy_class(). Fixes: fd62d9f ("net/sched: matchall: Fix configuration race") Reported-by: Li Shuang <[email protected]> Signed-off-by: Hangbin Liu <[email protected]> Acked-by: Cong Wang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent d01e12d commit a51c76b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

net/sched/cls_matchall.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ static void mall_destroy(struct tcf_proto *tp, struct netlink_ext_ack *extack)
113113
if (!head)
114114
return;
115115

116+
tcf_unbind_filter(tp, &head->res);
117+
116118
if (!tc_skip_hw(head->flags))
117119
mall_destroy_hw_filter(tp, head, (unsigned long) head, extack);
118120

0 commit comments

Comments
 (0)