Skip to content

Commit b04c99e

Browse files
committed
Revert "Input: introduce BTN/ABS bits for drums and guitars"
This reverts commits 61e0065, 73f8645 and 8e22ecb: "Input: introduce BTN/ABS bits for drums and guitars" "HID: wiimote: add support for Guitar-Hero drums" "HID: wiimote: add support for Guitar-Hero guitars" The extra new ABS_xx values resulted in ABS_MAX no longer being a power-of-two, which broke the comparison logic. It also caused the ioctl numbers to overflow into the next byte, causing problems for that. We'll try again for 3.13. Reported-by: Markus Trippelsdorf <[email protected]> Reported-by: Linus Torvalds <[email protected]> Acked-by: David Herrmann <[email protected]> Acked-by: Dmitry Torokhov <[email protected]> Cc: Benjamin Tissoires <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 44598f9 commit b04c99e

File tree

5 files changed

+3
-433
lines changed

5 files changed

+3
-433
lines changed

drivers/hid/hid-wiimote-core.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -455,12 +455,6 @@ static __u8 wiimote_cmd_read_ext(struct wiimote_data *wdata, __u8 *rmem)
455455
return WIIMOTE_EXT_BALANCE_BOARD;
456456
if (rmem[4] == 0x01 && rmem[5] == 0x20)
457457
return WIIMOTE_EXT_PRO_CONTROLLER;
458-
if (rmem[0] == 0x01 && rmem[1] == 0x00 &&
459-
rmem[4] == 0x01 && rmem[5] == 0x03)
460-
return WIIMOTE_EXT_GUITAR_HERO_DRUMS;
461-
if (rmem[0] == 0x00 && rmem[1] == 0x00 &&
462-
rmem[4] == 0x01 && rmem[5] == 0x03)
463-
return WIIMOTE_EXT_GUITAR_HERO_GUITAR;
464458

465459
return WIIMOTE_EXT_UNKNOWN;
466460
}
@@ -494,8 +488,6 @@ static bool wiimote_cmd_map_mp(struct wiimote_data *wdata, __u8 exttype)
494488
/* map MP with correct pass-through mode */
495489
switch (exttype) {
496490
case WIIMOTE_EXT_CLASSIC_CONTROLLER:
497-
case WIIMOTE_EXT_GUITAR_HERO_DRUMS:
498-
case WIIMOTE_EXT_GUITAR_HERO_GUITAR:
499491
wmem = 0x07;
500492
break;
501493
case WIIMOTE_EXT_NUNCHUK:
@@ -1083,8 +1075,6 @@ static const char *wiimote_exttype_names[WIIMOTE_EXT_NUM] = {
10831075
[WIIMOTE_EXT_CLASSIC_CONTROLLER] = "Nintendo Wii Classic Controller",
10841076
[WIIMOTE_EXT_BALANCE_BOARD] = "Nintendo Wii Balance Board",
10851077
[WIIMOTE_EXT_PRO_CONTROLLER] = "Nintendo Wii U Pro Controller",
1086-
[WIIMOTE_EXT_GUITAR_HERO_DRUMS] = "Nintendo Wii Guitar Hero Drums",
1087-
[WIIMOTE_EXT_GUITAR_HERO_GUITAR] = "Nintendo Wii Guitar Hero Guitar",
10881078
};
10891079

10901080
/*
@@ -1670,10 +1660,6 @@ static ssize_t wiimote_ext_show(struct device *dev,
16701660
return sprintf(buf, "balanceboard\n");
16711661
case WIIMOTE_EXT_PRO_CONTROLLER:
16721662
return sprintf(buf, "procontroller\n");
1673-
case WIIMOTE_EXT_GUITAR_HERO_DRUMS:
1674-
return sprintf(buf, "drums\n");
1675-
case WIIMOTE_EXT_GUITAR_HERO_GUITAR:
1676-
return sprintf(buf, "guitar\n");
16771663
case WIIMOTE_EXT_UNKNOWN:
16781664
/* fallthrough */
16791665
default:

0 commit comments

Comments
 (0)