Skip to content

Commit be59b61

Browse files
committed
memory: omap-gpmc: Fix unselectable debug option for GPMC
Commit 63aa945 ("memory: omap-gpmc: Add Kconfig option for debug") added a debug option for GPMC, but somehow managed to keep it unselectable. This probably happened because I had some uncommitted changes and the GPMC option is selected in the platform specific Kconfig. Let's also update the description a bit, it does not mention that enabling the debug option also disables the reset of GPMC controller during the init as pointed out by Uwe Kleine-König <[email protected]> and Roger Quadros <[email protected]>. Fixes: 63aa945 ("memory: omap-gpmc: Add Kconfig option for debug") Reported-by: Uwe Kleine-König <[email protected]> Acked-by: Roger Quadros <[email protected]> Signed-off-by: Tony Lindgren <[email protected]>
1 parent 7e381ec commit be59b61

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

drivers/memory/Kconfig

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,18 @@ config OMAP_GPMC
5858
memory drives like NOR, NAND, OneNAND, SRAM.
5959

6060
config OMAP_GPMC_DEBUG
61-
bool
61+
bool "Enable GPMC debug output and skip reset of GPMC during init"
6262
depends on OMAP_GPMC
6363
help
6464
Enables verbose debugging mostly to decode the bootloader provided
65-
timings. Enable this during development to configure devices
66-
connected to the GPMC bus.
65+
timings. To preserve the bootloader provided timings, the reset
66+
of GPMC is skipped during init. Enable this during development to
67+
configure devices connected to the GPMC bus.
68+
69+
NOTE: In addition to matching the register setup with the bootloader
70+
you also need to match the GPMC FCLK frequency used by the
71+
bootloader or else the GPMC timings won't be identical with the
72+
bootloader timings.
6773

6874
config MVEBU_DEVBUS
6975
bool "Marvell EBU Device Bus Controller"

0 commit comments

Comments
 (0)