Skip to content

Commit c0da6b7

Browse files
Dag MoxnesSomasundaram Krishnasamy
authored andcommitted
rds: ib: __flush_neigh_conn error messages in syslog during failover/failback
If RDS fails to find the device for an IP address when flushing the neighbor cache, it is likely be caused by the IP address being moved due to a failover/failback. Do not log an error in this case. Orabug: 30478312 Signed-off-by: Dag Moxnes <[email protected]> Reviewed-by: Ka-Cheong Poon <[email protected]> Signed-off-by: Somasundaram Krishnasamy <[email protected]>
1 parent c58993a commit c0da6b7

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

net/rds/ib.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -886,7 +886,9 @@ static void __flush_neigh_conn(struct net *net,
886886
isv4 = ipv6_addr_v4mapped(faddr);
887887

888888
/* Use our local address to find the right interface to flush the
889-
* neighbor address.
889+
* neighbor address. If we are unable to find the interface, this is
890+
* likely because the IP-address moved due to failover/failback, so
891+
* don't log any issues in this case.
890892
*/
891893
if (isv4) {
892894
idx = __rds_find_ifindex_v4(net, laddr->s6_addr32[3]);
@@ -896,11 +898,8 @@ static void __flush_neigh_conn(struct net *net,
896898
addrlen = sizeof(*faddr);
897899
}
898900

899-
if (!idx) {
900-
pr_err_ratelimited("%s: cannot find %pI6c interface\n",
901-
__func__, laddr);
901+
if (!idx)
902902
return;
903-
}
904903

905904
buflen = nlmsg_total_size(sizeof(*ndm) +
906905
nla_total_size(addrlen));

0 commit comments

Comments
 (0)