Skip to content

Commit c3968a8

Browse files
sahnedavem330
authored andcommitted
ipv6: RTA_PREFSRC support for ipv6 route source address selection
[ipv6] Add support for RTA_PREFSRC This patch allows a user to select the preferred source address for a specific IPv6-Route. It can be set via a netlink message setting RTA_PREFSRC to a valid IPv6 address which must be up on the device the route will be bound to. Signed-off-by: Daniel Walter <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent bd01592 commit c3968a8

File tree

5 files changed

+84
-7
lines changed

5 files changed

+84
-7
lines changed

include/net/ip6_fib.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ struct fib6_config {
4242

4343
struct in6_addr fc_dst;
4444
struct in6_addr fc_src;
45+
struct in6_addr fc_prefsrc;
4546
struct in6_addr fc_gateway;
4647

4748
unsigned long fc_expires;
@@ -107,6 +108,7 @@ struct rt6_info {
107108
struct rt6key rt6i_dst ____cacheline_aligned_in_smp;
108109
u32 rt6i_flags;
109110
struct rt6key rt6i_src;
111+
struct rt6key rt6i_prefsrc;
110112
u32 rt6i_metric;
111113
u32 rt6i_peer_genid;
112114

include/net/ip6_route.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ extern int ip6_route_add(struct fib6_config *cfg);
8484
extern int ip6_ins_rt(struct rt6_info *);
8585
extern int ip6_del_rt(struct rt6_info *);
8686

87+
extern int ip6_route_get_saddr(struct net *net,
88+
struct rt6_info *rt,
89+
struct in6_addr *daddr,
90+
unsigned int prefs,
91+
struct in6_addr *saddr);
92+
8793
extern struct rt6_info *rt6_lookup(struct net *net,
8894
const struct in6_addr *daddr,
8995
const struct in6_addr *saddr,
@@ -141,6 +147,7 @@ struct rt6_rtnl_dump_arg {
141147
extern int rt6_dump_route(struct rt6_info *rt, void *p_arg);
142148
extern void rt6_ifdown(struct net *net, struct net_device *dev);
143149
extern void rt6_mtu_change(struct net_device *dev, unsigned mtu);
150+
extern void rt6_remove_prefsrc(struct inet6_ifaddr *ifp);
144151

145152

146153
/*

net/ipv6/addrconf.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -825,6 +825,8 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp)
825825
dst_release(&rt->dst);
826826
}
827827

828+
/* clean up prefsrc entries */
829+
rt6_remove_prefsrc(ifp);
828830
out:
829831
in6_ifa_put(ifp);
830832
}

net/ipv6/ip6_output.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -930,10 +930,10 @@ static int ip6_dst_lookup_tail(struct sock *sk,
930930
goto out_err_release;
931931

932932
if (ipv6_addr_any(&fl6->saddr)) {
933-
err = ipv6_dev_get_saddr(net, ip6_dst_idev(*dst)->dev,
934-
&fl6->daddr,
935-
sk ? inet6_sk(sk)->srcprefs : 0,
936-
&fl6->saddr);
933+
struct rt6_info *rt = (struct rt6_info *) *dst;
934+
err = ip6_route_get_saddr(net, rt, &fl6->daddr,
935+
sk ? inet6_sk(sk)->srcprefs : 0,
936+
&fl6->saddr);
937937
if (err)
938938
goto out_err_release;
939939
}

net/ipv6/route.c

Lines changed: 69 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,6 +1325,16 @@ int ip6_route_add(struct fib6_config *cfg)
13251325
if (dev == NULL)
13261326
goto out;
13271327

1328+
if (!ipv6_addr_any(&cfg->fc_prefsrc)) {
1329+
if (!ipv6_chk_addr(net, &cfg->fc_prefsrc, dev, 0)) {
1330+
err = -EINVAL;
1331+
goto out;
1332+
}
1333+
ipv6_addr_copy(&rt->rt6i_prefsrc.addr, &cfg->fc_prefsrc);
1334+
rt->rt6i_prefsrc.plen = 128;
1335+
} else
1336+
rt->rt6i_prefsrc.plen = 0;
1337+
13281338
if (cfg->fc_flags & (RTF_GATEWAY | RTF_NONEXTHOP)) {
13291339
rt->rt6i_nexthop = __neigh_lookup_errno(&nd_tbl, &rt->rt6i_gateway, dev);
13301340
if (IS_ERR(rt->rt6i_nexthop)) {
@@ -2037,6 +2047,55 @@ struct rt6_info *addrconf_dst_alloc(struct inet6_dev *idev,
20372047
return rt;
20382048
}
20392049

2050+
int ip6_route_get_saddr(struct net *net,
2051+
struct rt6_info *rt,
2052+
struct in6_addr *daddr,
2053+
unsigned int prefs,
2054+
struct in6_addr *saddr)
2055+
{
2056+
struct inet6_dev *idev = ip6_dst_idev((struct dst_entry*)rt);
2057+
int err = 0;
2058+
if (rt->rt6i_prefsrc.plen)
2059+
ipv6_addr_copy(saddr, &rt->rt6i_prefsrc.addr);
2060+
else
2061+
err = ipv6_dev_get_saddr(net, idev ? idev->dev : NULL,
2062+
daddr, prefs, saddr);
2063+
return err;
2064+
}
2065+
2066+
/* remove deleted ip from prefsrc entries */
2067+
struct arg_dev_net_ip {
2068+
struct net_device *dev;
2069+
struct net *net;
2070+
struct in6_addr *addr;
2071+
};
2072+
2073+
static int fib6_remove_prefsrc(struct rt6_info *rt, void *arg)
2074+
{
2075+
struct net_device *dev = ((struct arg_dev_net_ip *)arg)->dev;
2076+
struct net *net = ((struct arg_dev_net_ip *)arg)->net;
2077+
struct in6_addr *addr = ((struct arg_dev_net_ip *)arg)->addr;
2078+
2079+
if (((void *)rt->rt6i_dev == dev || dev == NULL) &&
2080+
rt != net->ipv6.ip6_null_entry &&
2081+
ipv6_addr_equal(addr, &rt->rt6i_prefsrc.addr)) {
2082+
/* remove prefsrc entry */
2083+
rt->rt6i_prefsrc.plen = 0;
2084+
}
2085+
return 0;
2086+
}
2087+
2088+
void rt6_remove_prefsrc(struct inet6_ifaddr *ifp)
2089+
{
2090+
struct net *net = dev_net(ifp->idev->dev);
2091+
struct arg_dev_net_ip adni = {
2092+
.dev = ifp->idev->dev,
2093+
.net = net,
2094+
.addr = &ifp->addr,
2095+
};
2096+
fib6_clean_all(net, fib6_remove_prefsrc, 0, &adni);
2097+
}
2098+
20402099
struct arg_dev_net {
20412100
struct net_device *dev;
20422101
struct net *net;
@@ -2183,6 +2242,9 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh,
21832242
nla_memcpy(&cfg->fc_src, tb[RTA_SRC], plen);
21842243
}
21852244

2245+
if (tb[RTA_PREFSRC])
2246+
nla_memcpy(&cfg->fc_prefsrc, tb[RTA_PREFSRC], 16);
2247+
21862248
if (tb[RTA_OIF])
21872249
cfg->fc_ifindex = nla_get_u32(tb[RTA_OIF]);
21882250

@@ -2325,13 +2387,17 @@ static int rt6_fill_node(struct net *net,
23252387
#endif
23262388
NLA_PUT_U32(skb, RTA_IIF, iif);
23272389
} else if (dst) {
2328-
struct inet6_dev *idev = ip6_dst_idev(&rt->dst);
23292390
struct in6_addr saddr_buf;
2330-
if (ipv6_dev_get_saddr(net, idev ? idev->dev : NULL,
2331-
dst, 0, &saddr_buf) == 0)
2391+
if (ip6_route_get_saddr(net, rt, dst, 0, &saddr_buf) == 0)
23322392
NLA_PUT(skb, RTA_PREFSRC, 16, &saddr_buf);
23332393
}
23342394

2395+
if (rt->rt6i_prefsrc.plen) {
2396+
struct in6_addr saddr_buf;
2397+
ipv6_addr_copy(&saddr_buf, &rt->rt6i_prefsrc.addr);
2398+
NLA_PUT(skb, RTA_PREFSRC, 16, &saddr_buf);
2399+
}
2400+
23352401
if (rtnetlink_put_metrics(skb, dst_metrics_ptr(&rt->dst)) < 0)
23362402
goto nla_put_failure;
23372403

0 commit comments

Comments
 (0)