Skip to content

Commit c784a28

Browse files
YueHaibingdavem330
authored andcommitted
net/mlx5e: Remove set but not used variable 'upriv'
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_load': drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1490:21: warning: variable 'upriv' set but not used [-Wunused-but-set-variable] drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_unload': drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1557:21: warning: variable 'upriv' set but not used [-Wunused-but-set-variable] It not used any more since commit ef38135 ("net/mlx5e: Replace egdev with indirect block notifications"). Also remove unused variable 'uplink_rpriv' after this change. Signed-off-by: YueHaibing <[email protected]> Reviewed-by: Leon Romanovsky <[email protected]> Acked-by: Saeed Mahameed <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 02e1dbe commit c784a28

File tree

1 file changed

+0
-10
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+0
-10
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1484,10 +1484,8 @@ mlx5e_nic_rep_unload(struct mlx5_eswitch_rep *rep)
14841484
static int
14851485
mlx5e_vport_rep_load(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
14861486
{
1487-
struct mlx5e_rep_priv *uplink_rpriv;
14881487
struct mlx5e_rep_priv *rpriv;
14891488
struct net_device *netdev;
1490-
struct mlx5e_priv *upriv;
14911489
int nch, err;
14921490

14931491
rpriv = kzalloc(sizeof(*rpriv), GFP_KERNEL);
@@ -1522,9 +1520,6 @@ mlx5e_vport_rep_load(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
15221520
goto err_detach_netdev;
15231521
}
15241522

1525-
uplink_rpriv = mlx5_eswitch_get_uplink_priv(dev->priv.eswitch, REP_ETH);
1526-
upriv = netdev_priv(uplink_rpriv->netdev);
1527-
15281523
err = register_netdev(netdev);
15291524
if (err) {
15301525
pr_warn("Failed to register representor netdev for vport %d\n",
@@ -1552,14 +1547,9 @@ mlx5e_vport_rep_unload(struct mlx5_eswitch_rep *rep)
15521547
struct mlx5e_rep_priv *rpriv = mlx5e_rep_to_rep_priv(rep);
15531548
struct net_device *netdev = rpriv->netdev;
15541549
struct mlx5e_priv *priv = netdev_priv(netdev);
1555-
struct mlx5e_rep_priv *uplink_rpriv;
15561550
void *ppriv = priv->ppriv;
1557-
struct mlx5e_priv *upriv;
15581551

15591552
unregister_netdev(netdev);
1560-
uplink_rpriv = mlx5_eswitch_get_uplink_priv(priv->mdev->priv.eswitch,
1561-
REP_ETH);
1562-
upriv = netdev_priv(uplink_rpriv->netdev);
15631553
mlx5e_rep_neigh_cleanup(rpriv);
15641554
mlx5e_detach_netdev(priv);
15651555
mlx5e_destroy_netdev(priv);

0 commit comments

Comments
 (0)