Skip to content

Commit da2f3b2

Browse files
Zhu Yanjunjgunthorpe
authored andcommitted
IB/rxe: avoid calling WARN_ON_ONCE twice
In the exit branch, WARN_ON_ONCE is called to show stack. So it is not necessary to call WARN_ON_ONCE before going to exit. Signed-off-by: Zhu Yanjun <[email protected]> Reviewed-by: Leon Romanovsky <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 5e6e78d commit da2f3b2

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/infiniband/sw/rxe/rxe_comp.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,6 @@ int rxe_completer(void *arg)
659659
qp->qp_timeout_jiffies)
660660
mod_timer(&qp->retrans_timer,
661661
jiffies + qp->qp_timeout_jiffies);
662-
WARN_ON_ONCE(skb);
663662
goto exit;
664663

665664
case COMPST_ERROR_RETRY:
@@ -673,7 +672,6 @@ int rxe_completer(void *arg)
673672

674673
/* there is nothing to retry in this case */
675674
if (!wqe || (wqe->state == wqe_state_posted)) {
676-
WARN_ON_ONCE(skb);
677675
goto exit;
678676
}
679677

@@ -702,7 +700,6 @@ int rxe_completer(void *arg)
702700
skb = NULL;
703701
}
704702

705-
WARN_ON_ONCE(skb);
706703
goto exit;
707704

708705
} else {
@@ -746,7 +743,6 @@ int rxe_completer(void *arg)
746743
skb = NULL;
747744
}
748745

749-
WARN_ON_ONCE(skb);
750746
goto exit;
751747
}
752748
}

0 commit comments

Comments
 (0)