Skip to content

Commit df568d8

Browse files
committed
scsi: Use 'depends' with LIBFC instead of 'select'.
LIBFC depends upon SCSI_FC_ATTRS and select's CRC32C. The only alternative would be to 'select' CRC32C and all of SCSI_FC_ATTRS direct and indirect dependencies in the Kconfig section for every LIBFCOE user which makes little sense. Subsequently, use 'depends' instead of 'select' for LIBFCOE too. Signed-off-by: David S. Miller <[email protected]>
1 parent afbe7af commit df568d8

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

drivers/scsi/Kconfig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -592,21 +592,21 @@ config LIBFC
592592

593593
config LIBFCOE
594594
tristate "LibFCoE module"
595-
select LIBFC
595+
depends on LIBFC
596596
---help---
597597
Library for Fibre Channel over Ethernet module
598598

599599
config FCOE
600600
tristate "FCoE module"
601601
depends on PCI
602-
select LIBFCOE
602+
depends on LIBFCOE
603603
---help---
604604
Fibre Channel over Ethernet module
605605

606606
config FCOE_FNIC
607607
tristate "Cisco FNIC Driver"
608608
depends on PCI && X86
609-
select LIBFCOE
609+
depends on LIBFCOE
610610
help
611611
This is support for the Cisco PCI-Express FCoE HBA.
612612

drivers/scsi/bnx2fc/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ config SCSI_BNX2X_FCOE
22
tristate "QLogic NetXtreme II FCoE support"
33
depends on PCI
44
depends on (IPV6 || IPV6=n)
5+
depends on LIBFC
6+
depends on LIBFCOE
57
select NETDEVICES
68
select ETHERNET
79
select NET_VENDOR_BROADCOM
8-
select LIBFC
9-
select LIBFCOE
1010
select CNIC
1111
---help---
1212
This driver supports FCoE offload for the QLogic NetXtreme II

drivers/scsi/qla2xxx/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ config SCSI_QLA_FC
3131
config TCM_QLA2XXX
3232
tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
3333
depends on SCSI_QLA_FC && TARGET_CORE
34-
select LIBFC
34+
depends on LIBFC
3535
select BTREE
3636
default n
3737
---help---

0 commit comments

Comments
 (0)