Skip to content

Commit e29129f

Browse files
Dan Carpenterdavem330
authored andcommitted
net: dsa: mv88e6xxx: missing unlock on error path
We added a new error path, but we need to drop the lock before we return. Fixes: 2d2e1dd ("net: dsa: mv88e6xxx: Cache the port cmode") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Andrew Lunn <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f6f7a26 commit e29129f

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/dsa/mv88e6xxx

1 file changed

+1
-1
lines changed

drivers/net/dsa/mv88e6xxx/chip.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2408,7 +2408,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
24082408
if (chip->info->ops->port_get_cmode) {
24092409
err = chip->info->ops->port_get_cmode(chip, i, &cmode);
24102410
if (err)
2411-
return err;
2411+
goto unlock;
24122412

24132413
chip->ports[i].cmode = cmode;
24142414
}

0 commit comments

Comments
 (0)