devlink: Remove misleading internal_flags from health reporter dump

rleon · davem330 · commit e9538f8270db · 2021-11-29T13:04:26.000Z
DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET command doesn't have .doit callback and has no use in internal_flags at all. Remove this misleading assignment. Fixes: e44ef4e ("devlink: Hang reporter's dump method on a dumpit cb") Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/core/devlink.c b/net/core/devlink.c
@@ -8845,8 +8845,6 @@ static const struct genl_small_ops devlink_nl_ops[] = {
 			    GENL_DONT_VALIDATE_DUMP_STRICT,
 		.dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,
 		.flags = GENL_ADMIN_PERM,
-		.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT |
-				  DEVLINK_NL_FLAG_NO_LOCK,
 	},
 	{
 		.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,

Original file line number	Diff line number	Diff line change
`@@ -8845,8 +8845,6 @@ static const struct genl_small_ops devlink_nl_ops[] = {`
`8845`	`8845`	`GENL_DONT_VALIDATE_DUMP_STRICT,`
`8846`	`8846`	`.dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,`
`8847`	`8847`	`.flags = GENL_ADMIN_PERM,`
`8848`		`- .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT \|`
`8849`		`- DEVLINK_NL_FLAG_NO_LOCK,`
`8850`	`8848`	`},`
`8851`	`8849`	`{`
`8852`	`8850`	`.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,`