Skip to content

Commit ec89756

Browse files
committed
usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is conditional upon USB && USB_SUPPORT, so that it can be freely selected by platform Kconfig symbols in architecture code. For example once the MIPS_GENERIC platform selects are fixed in commit 2e6522c ("MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN"), the MIPS 32r6_defconfig warns like so: warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB) warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB) Fixes: 2e6522c ("MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN") Signed-off-by: James Hogan <[email protected]> Cc: Corentin Labbe <[email protected]> Cc: Ralf Baechle <[email protected]> Cc: Paul Burton <[email protected]> Cc: [email protected] Cc: [email protected] Acked-by: Greg Kroah-Hartman <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/18559/
1 parent 67a3ba2 commit ec89756

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

drivers/usb/Kconfig

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@ config USB_EHCI_BIG_ENDIAN_MMIO
1919
config USB_EHCI_BIG_ENDIAN_DESC
2020
bool
2121

22+
config USB_UHCI_BIG_ENDIAN_MMIO
23+
bool
24+
default y if SPARC_LEON
25+
26+
config USB_UHCI_BIG_ENDIAN_DESC
27+
bool
28+
default y if SPARC_LEON
29+
2230
menuconfig USB_SUPPORT
2331
bool "USB support"
2432
depends on HAS_IOMEM

drivers/usb/host/Kconfig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -633,14 +633,6 @@ config USB_UHCI_ASPEED
633633
bool
634634
default y if ARCH_ASPEED
635635

636-
config USB_UHCI_BIG_ENDIAN_MMIO
637-
bool
638-
default y if SPARC_LEON
639-
640-
config USB_UHCI_BIG_ENDIAN_DESC
641-
bool
642-
default y if SPARC_LEON
643-
644636
config USB_FHCI_HCD
645637
tristate "Freescale QE USB Host Controller support"
646638
depends on OF_GPIO && QE_GPIO && QUICC_ENGINE

0 commit comments

Comments
 (0)