Skip to content

Commit fc64a2b

Browse files
committed
platform/x86: x86-android-tablets: Don't return -EPROBE_DEFER from a non probe() function
The x86-android-tablets code all runs from module_init, so returning -EPROBE_DEFER is not appropriate. Instead log an error and bail. This path should never get hit since PINCTRL_BAYTRAIL is a bool. Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 7a4af4b commit fc64a2b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/platform/x86/x86-android-tablets.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,10 @@ static int x86_acpi_irq_helper_get(const struct x86_acpi_irq_data *data)
6363
case X86_ACPI_IRQ_TYPE_GPIOINT:
6464
/* Like acpi_dev_gpio_irq_get(), but without parsing ACPI resources */
6565
chip = gpiochip_find(data->chip, x86_acpi_irq_helper_gpiochip_find);
66-
if (!chip)
67-
return -EPROBE_DEFER;
66+
if (!chip) {
67+
pr_err("error cannot find GPIO chip %s\n", data->chip);
68+
return -ENODEV;
69+
}
6870

6971
gpiod = gpiochip_get_desc(chip, data->index);
7072
if (IS_ERR(gpiod)) {

0 commit comments

Comments
 (0)