-
Notifications
You must be signed in to change notification settings - Fork 783
Packaging python scripts #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging python scripts #2389
Conversation
There's more to go as I'm not really skilled with maven.
|
5c15cd3
to
9ce60f9
Compare
If anyone can examined these it'd be nice. I didn't write the original scripts so I'm not sure if that was just a copy paste mistake.
|
yes please. That said, each major script has its own version. |
The fixes to the lint errors look okay. |
|
149e6d3
to
dfe69d2
Compare
opengrok-tools/setup.py
Outdated
|
||
setup( | ||
name='opengrok-tools', | ||
version='1.1rc57', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way how to avoid hardcoding the version ? Should we be using OpenGrok version at all here actually ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maven can do it, I hope someone how is with better experience with maven can handle this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think about something what to do with the python package version (replace with the current opengrok version?)
yes please. That said, each major script has its own version.
You've already said that we should use the opengrok version, that's why I changed it.
The package opengrok_tools can be installed from the tarball, downloading all neccessary dependencies.
This will still break with different version scheme
Pls file a new issue to get the version number resolved. |
fixes #2251
This includes: