Using weak tag instead of just last modification date #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This enables us to reflect all other factors
which contribute to the resource freshness
the last file timestamp
messages on the project
the timestamp of last index
the opengrok version
- We assemble all these to the weak tag,
and the resource is reloaded only in any of these change
Pull Request Test Coverage Report for Build 3305
💛 - Coveralls |
vladak
reviewed
Oct 23, 2018
opengrok-indexer/src/main/java/org/opengrok/indexer/web/PageConfig.java
Outdated
Show resolved
Hide resolved
vladak
reviewed
Oct 23, 2018
opengrok-indexer/src/main/java/org/opengrok/indexer/web/PageConfig.java
Outdated
Show resolved
Hide resolved
vladak
reviewed
Oct 23, 2018
| @@ -56,11 +56,8 @@ | |||
| <filter-mapping> | |||
| <filter-name>ExpiresHalfHourFilter</filter-name> | |||
| <url-pattern>/history/*</url-pattern> | |||
There was a problem hiding this comment.
history does not include mast.jsp so this does not affect it anyway
There was a problem hiding this comment.
Does this mean that history page will not display any messages ?
There was a problem hiding this comment.
No. It means it will work like now, with sometimes inconsistent view as mentioned in #2405 because of the 30 minutes caching interval. This is also a subject to change if desired, but in different PR.
vladak
reviewed
Oct 23, 2018
vladak
reviewed
Oct 23, 2018
opengrok-indexer/src/main/java/org/opengrok/indexer/web/PageConfig.java
Outdated
Show resolved
Hide resolved
vladak
reviewed
Oct 23, 2018
opengrok-indexer/src/main/java/org/opengrok/indexer/web/PageConfig.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to reflect all other factors
which contribute to the resource freshness
We assemble all these to the weak tag,
and the resource is reloaded only in any of these change
OpenGrok version is added to the weak tag attributes because of utils.js. Until now event when we increase the version of utils.js, the cached xref still pointed to the old version causing some drama with javascript. This way with every new OpenGrok version, each xref will be reloaded (no need for ctrl+shift+R).
fixes #2405