Skip to content

asynchronous API #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2021
Merged

asynchronous API #3853

merged 1 commit into from
Dec 29, 2021

Conversation

vladak
Copy link
Member

@vladak vladak commented Dec 29, 2021 •
edited
Loading

This change introduces very simple framework for asynchronous API requests and adapts some of the API endpoints to use it. I made some tradeoff decisions like:

  • there is no way how to pass output/result from an API task so far
  • the clients need to employ busy wait in order to await the final state of an API task
  • the cleanup of the resources associated with an API task is explicit (DELETE)

https://github.com/oracle/opengrok/wiki/Indexer-configuration#indexer-tunables will have to be updated with connectTimeout and apiTimeout.

@vladak vladak added the API label Dec 29, 2021
ahornace
ahornace reviewed Dec 29, 2021
View reviewed changes
Copy link
Contributor

@ahornace ahornace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

ahornace
ahornace approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@ahornace ahornace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@vladak
Copy link
Member Author

vladak commented Dec 29, 2021

Looks good :)

Thanks !

@vladak
asynchronous API
dcb1fda 
make API calls to set configuration asynchronous

fixes oracle#3678
fixes oracle#3686
fixes oracle#3771
@vladak vladak merged commit 1c25812 into oracle:master Dec 29, 2021
@vladak vladak deleted the api_async branch December 29, 2021 19:50
This was referenced Dec 29, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahornace ahornace ahornace approved these changes

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladak @ahornace