WebLogic REST API sessions are now managed and should not grow #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
lennyphan
previously approved these changes
Jan 4, 2023
robertpatrick
previously approved these changes
Jan 4, 2023
rjeberhard
reviewed
Jan 4, 2023
wls-exporter-core/src/main/java/com/oracle/wls/exporter/AuthenticatedCall.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
rjeberhard
reviewed
Jan 4, 2023
| final Cookie cookie = new Cookie(cookieHeader); | ||
| COOKIES | ||
| .computeIfAbsent(context.getAuthenticationHeader(), h -> new ArrayList<>()) | ||
| .add(cookie); |
There was a problem hiding this comment.
You would need to synchronize around the add too.
There was a problem hiding this comment.
Oh, ignore... This is called under the other synchronized block.
rjeberhard
approved these changes
Jan 4, 2023
lennyphan
approved these changes
Jan 4, 2023
russgold
changed the title
russgold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST API creates sessions when it receives a request specifying login credentials; in order to prevent it from creating massive numbers of them, the exporter now acts as a web browser does, adding to its collection of web cookies when it receives a Set-Cookie header from the REST API, and sending a Cookie header to the API when it makes requests.