Skip to content

Filtering always uses the "name" field #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Conversation

russgold
Copy link
Member

@russgold russgold commented Jan 9, 2023

It turns out that the REST API requires all filtering to be on the name field (with a possible exception of some beans which don't appear to be runtime mbeans). This change uses that standard field name rather than the selected key field.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 9, 2023
@russgold russgold self-assigned this Jan 12, 2023
@russgold russgold marked this pull request as ready for review January 12, 2023 19:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@marinakog
Copy link
Member

@russgold russgold merged commit 35e2cbd into main Jan 13, 2023
@russgold russgold deleted the russ_always_filter_on_name branch January 13, 2023 01:01
@russgold russgold changed the title Russ always filter on name Filtering always uses the "name" field Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants