add gomodules support #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since travis-ci puts files in a constructed GOPATH by default, it will currently not bother with a detected go.mod (hence the `warning: modules disabled by GO111MODULE=auto in GOPATH/src`) message in install phase output. This is fine and things still build, but it's more robust to test using the defined modules. This change signals to use modules even when within a GOPATH, so that travis-ci will test with them.
Same as previous commit but for appveyor support. In this case it looks like the script is manually constructing the GOPATH. Since the appveyor version is currently only testing on stable 1.11, this change will enable the use of gomodules while in the gopath. (In the future if desired, since it only tests on stable and greater, the appveyor script could be modified to not have a GOPATH at all, and this env variable would not be necessary. But for now, doing the smallest possible change.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go Modules 📦 have been supported since Go 1.11 as the officially blessed "preliminary support" for dependency management and reproducible builds, and while the writing was on the wall for a while, it seems it's now official that this seems to be the path forward in the Go ecosystem.
This PR adds a standard go module definition for this repository (generated via
go mod initandgo mod tidy), indicating the current state of the dependency chain. This should simplify things for other people importing this library in their projects (like me!), as well as some other niceness like allowing working outside of GOPATH if desired.(Note: I'm not 100% certain, but I believe due to semantic versioning requirements any other programs which depend on this will not be able to actually take advantage until there is a tagged git release that includes it, even after it is merged.)