Return err when lookup fails. #52
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One would hope to be able to distinguish between an IP address with no registered country (or city) without examining each and every member of the returned struct, but that does not appear to be possible, because
maxminddb.Reader.Lookup
obscures the difference.This change breaks many tests that currently expect nil, even though a record was not found.
If it is desired that errors be reserved for operational issues, this information needs to be made available to
geoip2
frommaxminddb
so thatgeoip2
can return a nil for*City
or*Country
instead of an error.It would be possible to work around this issue without breaking the existing API by using
LookupOffset
andDecode
inmaxminddb
, but themaxminddb.Reader
instance is private ingeoip2
, so 3rd-party code can't reach it.Alternatively, in order to maintain strict backwards-compatibility, I could implement new methods in
geoip2.Reader
that would lookup records and behave as desired, but that would mean adding 7 new methods or a new mode for the 7 existing methods.