Skip to content

Feature/m UI item component state #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

sfryan95
Copy link
Collaborator

@sfryan95 sfryan95 commented Apr 24, 2024

Sean 4/23 integrated MUITypes into redux and appStateSlice; created DirectChildMUI and DirectChildMUINestable components; added MUI components to DragDropPanel component; updated MUITypes; updated associated imports

Co-author-by: Heather Pfeiffer [email protected]
Co-author-by: Jesse Wowczuk [email protected]
Co-author-by: Zack Vandiver [email protected]

Type of Change

Please check the options that apply

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • [ x ] My code follows the style guidelines of this project
  • [ x ] Changes included in this pull request covers minimal topic
  • [ x ] I have performed a self-review of my code
  • [ x ] I have commented my code properly, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] Any dependent changes have been merged and published in downstream modules

Zack Vandiver and others added 4 commits April 23, 2024 12:07
Co-authored-by: Heather Pfeiffer <[email protected]>
Co-authored-by: Jesse Wowczuk <[email protected]>
…irectChildMUI and DirectChildMUINestable components; added MUI components to DragDropPanel component; updated MUITypes; updated associated imports

>
>
Co-author-by: Heather Pfeiffer <[email protected]>
Co-author-by: Jesse Wowczuk <[email protected]>
Co-author-by: Zack Vandiver <[email protected]>
Co-author-by: Sean Ryan <sfryan95>
Copy link

@JesseWowczuk JesseWowczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is excellent! It not only resolves the reported issue efficiently but also improves code readability and maintainability. Well done!

Copy link

@HM-Pfeiffer HM-Pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I believe this submission sets a strong precedent for future development efforts. By effectively integrating Material-UI into our Redux project and adopting best practices for component organization, the team has laid a solid foundation for continued success. Keep up the excellent work!

@HM-Pfeiffer HM-Pfeiffer merged commit aaf7b18 into dev Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants