Fix: Support fallback values for ${param:x, fallback}
syntax in stage parameters
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores support for default/fallback values in
${param:...}
variable resolution syntax using the comma-separated fallback notation:${param:some_non_existent_parameter, 'subnet-0123456789'}
Previously, this behavior was supported in Serverless Framework (especially via Compose), but recent versions of the OSS fork began throwing errors when the primary param could not be resolved.
Issue
Given this input:
Users encountered:
This breaks compatibility with [the documented variable syntax](https://www.serverless.com/framework/docs/guides/variables#default-values) and behavior users depend on, especially when running through Compose.
Fix
Updated param resolution logic to support fallback values when primary param is not defined.
Removed hard-coded error throw on missing param and allowed fallback substitution.
Fixes Default values (${x,y} syntax) don't work if param x is not defined #56
Added tests:
MISSING_VARIABLE_RESULT
for unsupported formats.