Detect multiline imports and don't show snippets for them #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed changes in pyls/plugins/jedi_completion.py pyls_completions: Check variables before calling function. use_snippets: Include previous lines in parsed snippet if they ends with `\`; Limit splits count by line number; Check token type instead of token code.
|
@muffinmad, thanks a lot for the quick response! @steff456, please review this one. |
steff456
suggested changes
Nov 13, 2019
|
Besides requested changes, detection import in multi-statement lines is added. Although cases like a = 1; from datetime import dateand from datetime import date; a = dateare not commonly used, it's good to handle them correctly. Please see updated PR. Thanks! |
steff456
approved these changes
Nov 14, 2019
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in
pyls/plugins/jedi_completion.pypyls_completions: Check variables before calling function.use_snippets: Include previous lines in parsed snippet if they ends with\;Limit splits count by line number; Check token type instead of token code.