Skip to content

Add code in front of the diagnostic message for flake8 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

jdhao
Copy link
Contributor

@jdhao jdhao commented Nov 4, 2020

For the issue discussed in #884, it would be better to also add the code in front the actual diagnostic message, to make the message style the same as pycodestyle.

Fixes #884.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @jdhao! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ccordoba12
Copy link
Contributor

@jdhao, thanks a lot for this! Probably our tests for the flake8 plugin are failing due to the change you introduced, so you also need to fix them in this PR.

@jdhao
Copy link
Contributor Author

jdhao commented Nov 5, 2020

@jdhao, thanks a lot for this! Probably our tests for the flake8 plugin are failing due to the change you introduced, so you also need to fix them in this PR.

OK, it seems that I also need to update some of the test for flake8 plugin, as the msg format has changed.

@jdhao
Copy link
Contributor Author

jdhao commented Nov 6, 2020

@ccordoba12 I have fixed the bug. Please review it.

@ccordoba12 ccordoba12 added this to the 0.36.1 milestone Nov 7, 2020
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jdhao!

@ccordoba12 ccordoba12 merged commit 7a98c2c into palantir:develop Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be better to keep output from the flake8 linter to be consistent with that of pycodestyle.
3 participants