Type tolerance in reindex_like, remove unused function
#1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Feb 7, 2025
Dr-Irv
requested changes
Feb 7, 2025
|
thanks for your review! |
Dr-Irv
requested changes
Feb 7, 2025
There was a problem hiding this comment.
I may have not been clear in my last review, but I think we should remove reindex_like() stub from core/generic.pyi since it is overridden by what is in series.pyi and frame.pyi.
When we do PR's like this one, it allows me to find cases where we have the unnecessary duplication.
So if you make that change, then we should be good to go.
|
ah sorry i thought you meant just the |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value