GH1103 Fixes for Dataframe.squeeze and Series.squeeze
#1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangdanny97
changed the title
Dataframe.squeeze and Series.squeezeDataframe.squeeze and Series.squeeze
Dr-Irv
requested changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following based on #1103 and https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.squeeze.html
add a return type annotation to Dataframe.squeeze
remove the axis parameter for Series.squeeze, as the docs say "For Series this parameter is unused and defaults to None."
add Series as a possible return type for Series.squeeze. I think since it only happens when the object is returned unchanged, the dtype is the same as the original.
add unit tests for the different possible returns (I'm not sure whether
assert_typeprovides any value here, since the return is just a union)Closes Series.squeeze return type should be a Series or Scalar #1103
Tests added: Please use
assert_type()to assert the type of any return value