fix issues 302, 314, 320, 321 #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
commented
Sep 24, 2022
| @@ -150,28 +151,25 @@ class _LocIndexerFrame(_LocIndexer): | |||
| @overload | |||
| def __getitem__( | |||
| self, | |||
| idx: tuple[int | StrLike | tuple[HashableT, ...], int | StrLike], | |||
| idx: tuple[int | StrLike | tuple[ScalarT, ...], int | StrLike], | |||
There was a problem hiding this comment.
HashableT included slice and if it is a slice in the tuple, we are not getting a scalar with .loc
twoertwein
approved these changes
Sep 24, 2022
|
Thanks @Dr-Irv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues found when writing some new code and checking some old code:
test_frame.py:test_types_drop()modified to checkIndexas argumenttest_series.py:test_types_drop()modified to checkIndexas argumentIndexSlicein existing test functionstz_localize()and related methods that followWeekOfMonthandLastWeekOfMonth