Skip to content

Commit d106e99

Browse files
alimcmaster1jreback
authored andcommitted
Parameterize test cases (#24639)
1 parent 62a2a11 commit d106e99

File tree

1 file changed

+10
-22
lines changed

1 file changed

+10
-22
lines changed

pandas/tests/plotting/test_converter.py

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -239,29 +239,17 @@ def test_conversion_outofbounds_datetime(self):
239239
xp = converter.dates.date2num(values[0])
240240
assert rs == xp
241241

242-
def test_time_formatter(self):
242+
@pytest.mark.parametrize('time,format_expected', [
243+
(0, '00:00'), # time2num(datetime.time.min)
244+
(86399.999999, '23:59:59.999999'), # time2num(datetime.time.max)
245+
(90000, '01:00'),
246+
(3723, '01:02:03'),
247+
(39723.2, '11:02:03.200')
248+
])
249+
def test_time_formatter(self, time, format_expected):
243250
# issue 18478
244-
245-
# time2num(datetime.time.min)
246-
rs = self.tc(0)
247-
xp = '00:00'
248-
assert rs == xp
249-
250-
# time2num(datetime.time.max)
251-
rs = self.tc(86399.999999)
252-
xp = '23:59:59.999999'
253-
assert rs == xp
254-
255-
# some other times
256-
rs = self.tc(90000)
257-
xp = '01:00'
258-
assert rs == xp
259-
rs = self.tc(3723)
260-
xp = '01:02:03'
261-
assert rs == xp
262-
rs = self.tc(39723.2)
263-
xp = '11:02:03.200'
264-
assert rs == xp
251+
result = self.tc(time)
252+
assert result == format_expected
265253

266254
def test_dateindex_conversion(self):
267255
decimals = 9

0 commit comments

Comments
 (0)