Skip to content

CLN: Parameterize test cases #24639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2019
Merged

CLN: Parameterize test cases #24639

merged 1 commit into from
Jan 5, 2019

Conversation

alimcmaster1
Copy link
Member

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jan 5, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

lgtm.

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24639 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24639      +/-   ##
==========================================
+ Coverage   92.37%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52388    52388              
==========================================
+ Hits        48396    48397       +1     
+ Misses       3992     3991       -1
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 42.99% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510afa7...179b534. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24639 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24639      +/-   ##
==========================================
+ Coverage   92.37%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52388    52388              
==========================================
+ Hits        48396    48397       +1     
+ Misses       3992     3991       -1
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 42.99% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510afa7...179b534. Read the comment docs.

@jreback jreback merged commit d106e99 into pandas-dev:master Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

thanks!

@alimcmaster1
Copy link
Member Author

Thanks for the review @jreback

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants