Skip to content

WEB: Test that our versions JSON is valid #61573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
datapythonista opened this issue Jun 5, 2025 · 0 comments · Fixed by #61578
Closed

WEB: Test that our versions JSON is valid #61573

datapythonista opened this issue Jun 5, 2025 · 0 comments · Fixed by #61578
Labels
good first issue Web pandas website

Comments

@datapythonista
Copy link
Member

See #61572

I think this can be as simple as loading the file with json.load when calling pandas_web.py. This way, if the file is not valid JSON the CI should break. But we need to double check that json.load fails if an extra comma is present.
iabhi4 added a commit to iabhi4/pandas that referenced this issue Jun 5, 2025
@iabhi4
DOC: Validate versions.json before building docs pandas-dev#61573
b6edefe
@iabhi4 iabhi4 mentioned this issue Jun 5, 2025
Merged
1 task
iabhi4 added a commit to iabhi4/pandas that referenced this issue Jun 5, 2025
@iabhi4
DOC: Validate versions.json before building docs pandas-dev#61573
0aa4645
iabhi4 added a commit to iabhi4/pandas that referenced this issue Jun 5, 2025
@iabhi4
DOC: Validate versions.json before building docs pandas-dev#61573
f1d80fc
iabhi4 added a commit to iabhi4/pandas that referenced this issue Jun 6, 2025
@iabhi4
DOC: Validate versions.json before building docs pandas-dev#61573
93d9d89
iabhi4 added a commit to iabhi4/pandas that referenced this issue Jun 6, 2025
@iabhi4
DOC: Validate versions.json before building docs pandas-dev#61573
89b8493
iabhi4 added a commit to iabhi4/pandas that referenced this issue Jun 6, 2025
@iabhi4
DOC: Validate versions.json before building docs pandas-dev#61573
57bbd0f
iabhi4 added a commit to iabhi4/pandas that referenced this issue Jun 6, 2025
@iabhi4
DOC: Validate versions.json before building docs pandas-dev#61573
6eaa177
datapythonista pushed a commit that referenced this issue Jun 7, 2025
@iabhi4
DOC: Validate versions.json before building docs #61573 (#61578)
2096b28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Web pandas website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC: Validate versions.json before building docs #61573 iabhi4/pandas
1 participant
@datapythonista